Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUILD] 'uint8_t' not declared in this scope with gcc 13.2.1 #2423

Merged
merged 2 commits into from
Dec 5, 2023
Merged

[BUILD] 'uint8_t' not declared in this scope with gcc 13.2.1 #2423

merged 2 commits into from
Dec 5, 2023

Conversation

Thomas-Barbier-1A
Copy link
Contributor

@Thomas-Barbier-1A Thomas-Barbier-1A commented Dec 1, 2023 •
edited by marcalff
Loading

Changes

Added missing header file in hex.h, required to declare uint8_t

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@Thomas-Barbier-1A Thomas-Barbier-1A requested a review from a team December 1, 2023 13:08
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Dec 1, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Thomas-Barbier-1A (62bd89c)
  • ✅ login: ThomsonTan / name: Tom Tan (3c220c9)

owent
owent approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the CLA is signed

@codecov Codecov
Copy link

codecov bot commented Dec 1, 2023 •
edited
Loading

Codecov Report

Merging #2423 (62bd89c) into main (abad83d) will not change coverage.
The diff coverage is n/a.

❗ Current head 62bd89c differs from pull request most recent head 3c220c9. Consider uploading reports for the commit 3c220c9 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2423   +/-   ##
=======================================
  Coverage   87.06%   87.06%           
=======================================
  Files         199      199           
  Lines        6079     6079           
=======================================
  Hits         5292     5292           
  Misses        787      787
Files Coverage Δ
...clude/opentelemetry/trace/propagation/detail/hex.h 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@lalitb lalitb added the pr:waiting-on-cla Waiting on CLA label Dec 1, 2023
@Thomas-Barbier-1A
Copy link
Contributor Author

Thank you very much! I should be able to get the CLA signed by Monday: There is already an agreement in my company but I need to be added to a list of contributors by someone who will be back on Monday.

ThomsonTan
ThomsonTan approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@ThomsonTan ThomsonTan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Please also fix the format of include order.

@Thomas-Barbier-1A Thomas-Barbier-1A force-pushed the fix_error_uint8_t_not_declared branch from 359d06d to 62bd89c Compare December 1, 2023 17:22
@marcalff marcalff mentioned this pull request Dec 4, 2023
Closed
@marcalff marcalff changed the title Fix error: 'uint8_t' was not declared in this scope with gcc 13.2.1 [BUILD] 'uint8_t' not declared in this scope with gcc 13.2.1 Dec 4, 2023
@Thomas-Barbier-1A
Copy link
Contributor Author

Thomas-Barbier-1A commented Dec 5, 2023 •
edited
Loading

Sorry for the delay, it took me a bit more time to get the CLA is signed. But it is now signed :-)

@marcalff marcalff removed the pr:waiting-on-cla Waiting on CLA label Dec 5, 2023
@marcalff marcalff merged commit d1143ab into open-telemetry:main Dec 5, 2023
44 checks passed
@Porkepix Porkepix mentioned this pull request Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcalff marcalff marcalff approved these changes

@owent owent owent approved these changes

@lalitb lalitb lalitb approved these changes

@ThomsonTan ThomsonTan ThomsonTan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Thomas-Barbier-1A @ThomsonTan @lalitb @owent @marcalff