-
Notifications
You must be signed in to change notification settings - Fork 849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support explicit endpoint for Prometheus exporter. #6071
Comments
Moving to |
I'm happy to implement this after #6015 is merged, it should be straightforward. I'm wondering: The Prometheus In the OTel SDK we left the previous behavior, exporting metrics on all HTTP paths. However, we could change the default as well and only export metrics on What do you think? |
What about going in the prometheus Some data points:
Note, to add a new environment variable like |
@fstab are you still looking to pick this up? It seems reasonable to me, but I have no idea if someone might be relying on the root path Having it be specific makes sense to me tho....and |
Thanks for the ping. Yes, I'll have a look, at the latest next week. |
I created #6476. |
This will be available in 1.39.0, approximately tomorrow. Thanks! |
Is your feature request related to a problem? Please describe.
Long story short: Prometheus exporter responds to GET requests on any path/endpoint:
In my case, I didn't notice a missing update in a k8s manifest - custom listener on port 12321 used to handle both metrics and liveness/readiness. I've switched liveness to the application port, and kept 12321 for Prometheus exporter. I forgot to update the probes, and the exporter responded with 200 OK to probe calls on /liveness and /readiness, thus hiding the missconfiguration.
Describe the solution you'd like
New enviromental variable:
OTEL_EXPORTER_PROMETHEUS_PATH=/metrics
or:
OTEL_EXPORTER_PROMETHEUS_PATHS=/metrics,/foo,/
Also, 404 response for requests that do not match the endpoint.
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: