Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix graal #6134

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Fix graal #6134

merged 2 commits into from
Jan 11, 2024

Conversation

jack-berg
Copy link
Member

Fixes open-telemetry/opentelemetry-java-instrumentation#10184

Probably need to publish a patch release for this. cc @open-telemetry/java-approvers

@jack-berg jack-berg requested a review from a team January 9, 2024 19:17
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d9f9812) 91.01% compared to head (e0d48bf) 91.00%.

❗ Current head e0d48bf differs from pull request most recent head d189aab. Consider uploading reports for the commit d189aab to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6134      +/-   ##
============================================
- Coverage     91.01%   91.00%   -0.01%     
  Complexity     5702     5702              
============================================
  Files           630      630              
  Lines         16710    16710              
  Branches       1656     1656              
============================================
- Hits          15208    15207       -1     
  Misses         1047     1047              
- Partials        455      456       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment for explanation.

Looking closer at this, where does this package access version.properties? If source code needs to access the artifact version, it uses the generated OtelVersion.VERSION constant, as shown here: https://github.com/open-telemetry/opentelemetry-java/blob/main/sdk/common/src/main/java/io/opentelemetry/sdk/resources/Resource.java#L60
Not sure what this change aimed to accomplish.

@trask
Copy link
Member

trask commented Jan 11, 2024

Probably need to publish a patch release for this.

👍 I think it would be nice to have this fix for Instrumentation 2.0.0

@jack-berg jack-berg merged commit 38b2489 into open-telemetry:main Jan 11, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow failed: GraalVM native tests (#207)
2 participants