Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate graal RetryPolicy issue #6139

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

jack-berg
Copy link
Member

Resolves #6127.

@jack-berg jack-berg requested a review from a team January 10, 2024 23:05
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d9f9812) 91.01% compared to head (98f4ac2) 91.01%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6139   +/-   ##
=========================================
  Coverage     91.01%   91.01%           
- Complexity     5702     5703    +1     
=========================================
  Files           630      630           
  Lines         16710    16710           
  Branches       1656     1656           
=========================================
  Hits          15208    15208           
  Misses         1047     1047           
  Partials        455      455           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jack-berg jack-berg force-pushed the recreate-graal-issue branch from 7017cc8 to 69d113b Compare January 10, 2024 23:15
@trask
Copy link
Member

trask commented Jan 11, 2024

is this a workaround for a Graal bug? I don't see any reflective access for RetryPolicy

cc @jeanbisutti

@jack-berg
Copy link
Member Author

is this a workaround for a Graal bug? I don't see any reflective access for RetryPolicy

That was my conclusion in this comment. The fact that this doesn't occur in a different version of graal does suggest some sort of regression in the compiler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraalVM - Improve compatibility with native images
2 participants