Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default exporter for Node.js to 'otlp/proto'? #3423

Open
trentm opened this issue Nov 6, 2024 · 0 comments
Open

change default exporter for Node.js to 'otlp/proto'? #3423

trentm opened this issue Nov 6, 2024 · 0 comments

Comments

@trentm
Copy link

trentm commented Nov 6, 2024

By default the NodeSDK will use the http/proto trace exporter. Over time http/proto has become the default OTLP protocol used by most OTel languages. You can see this somewhat from the YAML configuration for the OTel Operator Instrumentation given here: https://github.com/open-telemetry/opentelemetry-operator/blob/main/README.md#opentelemetry-auto-instrumentation-injection

It sets the default exporter to http://otel-collector:4317, which is gRPC, but then has custom env for most languages to change to http://otel-collector:4318, which is an HTTP endpoint (for receiving either http/proto or http/json).

I haven't been involved much with the OTel Operator, but I wonder if it would consider switching the default for nodejs over to http://otel-collector:4318 as well. I realize that would be a breaking change.

The benefit is that "autoinstrumentation.ts" could just use the NodeSDK defaults, and not have to handle selecting a traceExporter at all. The NodeSDK's envvar handling will do the right thing.

Originally posted by @trentm in #3413 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant