From 19d67831c4928cdd37f141ad222d9d7abb9ed1b0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Robert=20Paj=C4=85k?= Date: Fri, 6 Dec 2024 00:39:36 +0100 Subject: [PATCH] Remove the recommendation to not synchronize access to Config.disabled (#4310) --- CHANGELOG.md | 6 ++++++ specification/logs/sdk.md | 4 +--- specification/metrics/sdk.md | 4 +--- specification/trace/sdk.md | 4 +--- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1e848eb50af..a781750a2d2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,16 +16,22 @@ release. - Add in-development support for `otlp/stdout` exporter via `OTEL_TRACES_EXPORTER`. ([#4183](https://github.com/open-telemetry/opentelemetry-specification/pull/4183)) +- Remove the recommendation to not synchronize access to `TracerConfig.disabled`. + ([#4310](https://github.com/open-telemetry/opentelemetry-specification/pull/4310)) ### Metrics - Add in-development support for `otlp/stdout` exporter via `OTEL_METRICS_EXPORTER`. ([#4183](https://github.com/open-telemetry/opentelemetry-specification/pull/4183)) +- Remove the recommendation to not synchronize access to `MeterConfig.disabled`. + ([#4310](https://github.com/open-telemetry/opentelemetry-specification/pull/4310)) ### Logs - Add in-development support for `otlp/stdout` exporter via `OTEL_LOGS_EXPORTER`. ([#4183](https://github.com/open-telemetry/opentelemetry-specification/pull/4183)) +- Remove the recommendation to not synchronize access to `LoggerConfig.disabled`. + ([#4310](https://github.com/open-telemetry/opentelemetry-specification/pull/4310)) ### Events diff --git a/specification/logs/sdk.md b/specification/logs/sdk.md index d382cde2447..190c723dda4 100644 --- a/specification/logs/sdk.md +++ b/specification/logs/sdk.md @@ -190,9 +190,7 @@ It consists of the following parameters: is [Enabled](./api.md#enabled). If `disabled` is `true`, `Enabled` returns `false`. If `disabled` is `false`, `Enabled` returns `true`. It is not necessary for implementations to ensure that changes to `disabled` are - immediately visible to callers of `Enabled`. I.e. atomic, volatile, - synchronized, or equivalent memory semantics to avoid stale reads are - discouraged to prioritize performance over immediate consistency. + immediately visible to callers of `Enabled`. ## Additional LogRecord interfaces diff --git a/specification/metrics/sdk.md b/specification/metrics/sdk.md index 325c252fd7e..003b1538e66 100644 --- a/specification/metrics/sdk.md +++ b/specification/metrics/sdk.md @@ -973,9 +973,7 @@ default `MeterConfig.disabled=false` and instruments use the default aggregation when no matching views match the instrument. It is not necessary for implementations to ensure that changes -to `MeterConfig.disabled` are immediately visible to callers of `Enabled`. I.e. -atomic, volatile, synchronized, or equivalent memory semantics to avoid stale -reads are discouraged to prioritize performance over immediate consistency. +to `MeterConfig.disabled` are immediately visible to callers of `Enabled`. ## Attribute limits diff --git a/specification/trace/sdk.md b/specification/trace/sdk.md index 765edc4b296..03f5b629a35 100644 --- a/specification/trace/sdk.md +++ b/specification/trace/sdk.md @@ -184,9 +184,7 @@ It consists of the following parameters: is [Enabled](./api.md#enabled). If `disabled` is `true`, `Enabled` returns `false`. If `disabled` is `false`, `Enabled` returns `true`. It is not necessary for implementations to ensure that changes to `disabled` are - immediately visible to callers of `Enabled`. I.e. atomic, volatile, - synchronized, or equivalent memory semantics to avoid stale reads are - discouraged to prioritize performance over immediate consistency. + immediately visible to callers of `Enabled`. ## Additional Span Interfaces