-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identify Links added after Span creation #3698
Comments
@carlosalberto are you going to work on this or we need help? |
We need to also identify links created before span creation since some SDKs might already be adding them after creation, so the status of all links at present is "unknown whether before or after creation" |
That sounds like off-spec behavior. I agree, however, that "unknown whether before or after creation" is acceptable for consumers. SDKs themselves are going to know the status of the link, since they created it, so in-SDK functionality is surely able to use this distinction whether it's recorded or not. |
@carlosalberto will you be the sponsor for this one? |
A follow up to #3678 is how to identify Links that have been added after Span creation. One idea has been to achieve this by adding a new
timestamp
field to the Links proto definition, so:This has been also indirectly discussed as part of #2918 - any chance to have the sampling working group discuss this, in case the aforementioned approach doesn't quite suit their needs?
cc @jmacd
The text was updated successfully, but these errors were encountered: