Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify Links added after Span creation #3698

Open
carlosalberto opened this issue Sep 20, 2023 · 4 comments
Open

Identify Links added after Span creation #3698

carlosalberto opened this issue Sep 20, 2023 · 4 comments
Labels
spec:trace Related to the specification/trace directory triage:accepted:needs-sponsor Ready to be implemented, but does not yet have a specification sponsor

Comments

@carlosalberto
Copy link
Contributor

A follow up to #3678 is how to identify Links that have been added after Span creation. One idea has been to achieve this by adding a new timestamp field to the Links proto definition, so:

  1. Links with timestamp = null are Links created at Span creation time (hence were available to the Sampling API)
  2. Links with timestamp != null are links created after Span creation time.

This has been also indirectly discussed as part of #2918 - any chance to have the sampling working group discuss this, in case the aforementioned approach doesn't quite suit their needs?

cc @jmacd

@tigrannajaryan tigrannajaryan added the [label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR label Nov 1, 2023
@tigrannajaryan
Copy link
Member

@carlosalberto are you going to work on this or we need help?

@tigrannajaryan tigrannajaryan added the spec:trace Related to the specification/trace directory label Nov 1, 2023
@tigrannajaryan tigrannajaryan removed their assignment Nov 1, 2023
@Oberon00
Copy link
Member

Oberon00 commented Nov 2, 2023

We need to also identify links created before span creation since some SDKs might already be adding them after creation, so the status of all links at present is "unknown whether before or after creation"

@jmacd
Copy link
Contributor

jmacd commented Feb 14, 2024

since some SDKs might already be adding them after creation

That sounds like off-spec behavior. I agree, however, that "unknown whether before or after creation" is acceptable for consumers. SDKs themselves are going to know the status of the link, since they created it, so in-SDK functionality is surely able to use this distinction whether it's recorded or not.

@svrnm svrnm added triage:accepted:needs-sponsor Ready to be implemented, but does not yet have a specification sponsor and removed [label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR labels May 6, 2024
@svrnm
Copy link
Member

svrnm commented May 6, 2024

@carlosalberto will you be the sponsor for this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:trace Related to the specification/trace directory triage:accepted:needs-sponsor Ready to be implemented, but does not yet have a specification sponsor
Projects
Status: Spec - Accepted
Development

No branches or pull requests

5 participants