-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conflicting/confusing requirements around InstrumentationScope attributes #3773
Comments
I see it as a similar issue to #3717 which I resolved via #3719. Maybe we should consider defining a |
CC @open-telemetry/specs-semconv-approvers |
@tigrannajaryan it seems we've deprecated Given how much time has passed, I'd be in favor of removing mentions of |
I agree. I suggest we do this carefully:
Given that the wording in the spec is confusing and conflicting I do not think we are bound by our stability guarantees and can treat it as a spec bug fix. |
If that document was stable, we can't remove without breaking compatibility. The problem seems to be that we have normative "MUST" language, which is stronger than the "RECOMMENDED" of the |
This appears to not be under active work, please update it when that changes. Thanks! |
In this part of the mapping-to-non-otlp.md file, the section that contains
otel.library.name
is confusing.I think the the intent was probably to require instrumentations to continue providing the old names for backwards compatibility. However, this section is really confusing to readers because it:
Why should attribute be Recommended, Deprecated, and MUST still contain a value?
The text was updated successfully, but these errors were encountered: