Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Span attribute keys have unspecified case sensitivity #3782

Closed
jorisgeer opened this issue Dec 4, 2023 · 6 comments · Fixed by #3784
Closed

Span attribute keys have unspecified case sensitivity #3782

jorisgeer opened this issue Dec 4, 2023 · 6 comments · Fixed by #3784
Labels
help wanted Extra attention is needed [label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR

Comments

@jorisgeer
Copy link

What needs to be changed? Describe the update that is required.

The documentation does not state whether span attribute keys are case sensitive

What is the name + path of the page that needs changed? The relative path
and page title where you found a problem.

concepts/signals/traces/#attributes - Span Attributes

Additional context: anything else you can think about that would be helpful.

If attribute keys are meant to be case sensitive - in line with most common programming languages - , any vendor that treats them case insensitive will cause a collision. The other way around an intentional case variation will result in a mismatch.

@jorisgeer jorisgeer added the bug Something isn't working label Dec 4, 2023
@svrnm
Copy link
Member

svrnm commented Dec 4, 2023

Thank you for raising this issue. This needs to be clarified (and probably is?) via the specification, then we can apply the change accordingly. I am not 100% sure if this is specified.

@open-telemetry/specs-approvers can someone take a look? I found #504 but I might miss some conclusion on this question in the spec.

@pyohannes
Copy link
Contributor

Seems there's no explicit mention of this in the spec, but it's implicitly assumed that attribute names are case-sensitive.

Attributes are defined as Unicode sequences:

Every name MUST be a valid Unicode sequence.

And different Unicode sequences would be different attribute names.

It might be worth pointing this out explicitly.

@tigrannajaryan
Copy link
Member

@chalin
Copy link
Contributor

chalin commented Dec 4, 2023

@svrnm et al.: should this issue be transferred to the spec repo?

@tigrannajaryan tigrannajaryan transferred this issue from open-telemetry/opentelemetry.io Dec 4, 2023
@tigrannajaryan
Copy link
Member

@svrnm et al.: should this issue be transferred to the spec repo?

Yes, I think it belongs to spec. Moved.

@tigrannajaryan tigrannajaryan added [label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR help wanted Extra attention is needed and removed bug Something isn't working labels Dec 6, 2023
@tigrannajaryan
Copy link
Member

We need someone to submit a PR to clarify this in the spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed [label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants