-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Span attribute keys have unspecified case sensitivity #3782
Comments
Thank you for raising this issue. This needs to be clarified (and probably is?) via the specification, then we can apply the change accordingly. I am not 100% sure if this is specified. @open-telemetry/specs-approvers can someone take a look? I found #504 but I might miss some conclusion on this question in the spec. |
Seems there's no explicit mention of this in the spec, but it's implicitly assumed that attribute names are case-sensitive. Attributes are defined as Unicode sequences:
And different Unicode sequences would be different attribute names. It might be worth pointing this out explicitly. |
Perhaps clarify somewhere here: https://github.com/open-telemetry/opentelemetry-specification/tree/main/specification/common#attribute-collections |
@svrnm et al.: should this issue be transferred to the spec repo? |
Yes, I think it belongs to spec. Moved. |
We need someone to submit a PR to clarify this in the spec. |
What needs to be changed? Describe the update that is required.
The documentation does not state whether span attribute keys are case sensitive
What is the name + path of the page that needs changed? The relative path
and page title where you found a problem.
concepts/signals/traces/#attributes - Span Attributes
Additional context: anything else you can think about that would be helpful.
If attribute keys are meant to be case sensitive - in line with most common programming languages - , any vendor that treats them case insensitive will cause a collision. The other way around an intentional case variation will result in a mismatch.
The text was updated successfully, but these errors were encountered: