-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specification & OTEP relationship: Provide references to implemented OTEPs #3792
Comments
I really like this idea. I believe it may also help the PR review process when new specification is added if it explicitly calls out the OTEP which motivates it directly in the text. |
This sounds like good idea for easier traceability. One has to be careful to not rely too heavily on it though, linking to xEPs should not be a substitute for good documentation. For an example of what can happen, see Python the typing module. Where the documentation was for a long time lacking and often referring back to old PEPs, that by time became superseded by later improvements and instead provided out-of-date examples. python/cpython#91533 |
We will have a discussion in the upcoming TC meeting next year (2024). |
We don't have a project to assign this to yet, but this is on the GC to solve. |
Contributes to open-telemetry#3792
OTEPs 0035, 0099, 0122 are linked from https://github.com/open-telemetry/opentelemetry-proto/blob/main/docs/specification.md Marking as done. |
Contributes to open-telemetry#3792
Contributes to open-telemetry#3792
Contributes to open-telemetry#3792
We are looking for volunteers to edit the spec and add the references to OTEPs. |
I've updated the metrics related OTEPs. #4022 |
What are you trying to achieve?
Please take a look at this issue by @hterik: open-telemetry/opentelemetry.io#3685, the particular issue is that it is not clear from the Spec on Span Status), what the intend of this section is. Only after going into the Git Blame View, digging up a related PR and issue, I was able to find the OTEP 136 which provides examples & background on why things are specified this way.
This is only one instance of an issue I had a few times now: while reading the spec, I missed the full picture of where things are coming from and why they are the way they are. Knowing how things work, I looked for the right OTEP to learn more. Outsiders lack this knowledge.
Therefore, what I want to suggest with this issue, is that the specification has in-place back links to the OTEPs that have been implemented by a certain section. Ideally as close as possible to the content, e.g. in the case of
Span Status
this shouldn't be a Reference section at the very bottom of the page, but a footnote at the title, or a line at the beginning stating that this is implementing this and that OTEP.Many OTEPs contain a lot of valuable contextual details, so I think this would help people a lot to understand the specification better by having them accessible from the right spot in the spec.
Additional context.
So far I could identify the following places where a reference is provided:
opentelemetry-specification/specification/schemas/README.md
Line 78 in 3d60131
opentelemetry-specification/specification/metrics/README.md
Line 104 in 3d60131
opentelemetry-specification/specification/logs/data-model.md
Line 476 in 3d60131
opentelemetry-specification/experimental/trace/zpages.md
Line 27 in 3d60131
opentelemetry-specification/specification/configuration/file-configuration.md
Line 120 in 3d60131
Tracking
The text was updated successfully, but these errors were encountered: