New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snippers use different arithmetics than cooler for determining bins from coordinates #446

Open

Phlya opened this issue May 31, 2023 · 0 comments

Assignees

Labels

bug

Member

Phlya commented May 31, 2023

I think the logic here is wrong, compared to cooler:

cooltools/cooltools/api/snipping.py

Line 428 in 6fd5aea

lo1, hi1 = (s1 // binsize) - offset1, (e1 // binsize) - offset1

in case of the end not falling exactly on the bin edge, it should include the rightmost partially covered bin, but it doesn't.

gfudenberg added the bug label

agalitsyna self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment