Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid toast in absence of internet connectivity while loading client info. #1559

Open
danishjamal104 opened this issue Nov 15, 2020 · 2 comments · May be fixed by #1560 or #2049
Open

Invalid toast in absence of internet connectivity while loading client info. #1559

danishjamal104 opened this issue Nov 15, 2020 · 2 comments · May be fixed by #1560 or #2049
Labels
bug good first issue

Comments

@danishjamal104
Copy link
Collaborator

Summary:
After disconnecting from the internet invalid toast message is shown Client not found.

Steps to reproduce:

  • Step1- search for any clients on the dashboard page with has some result.
  • Step2- when the result is shown disconnect the device from the internet.
  • Step3- now click on any client and observe the toast.

Expected behaviour:
A proper message describing the issue must be displayed for example No internet connection for no internet connectivity case.

Observed behaviour:
When we disconnect the device from internet after loading the search result of client on dashboard then the detail page of client shows an incorrect toast of Client not found which instead should display No internet connection also the progress bar over profile picture goes into infinite loading which also must be disabled in absence of internet connectivity.

Device and Android version:

  • Device: Pixel 2 XL Emulator
  • Android Version: API 27 Android O(Oreo) - 8.1.0

Screenshots:

Screenshot 2020-11-15 at 10 44 03 PM
@danishjamal104
Copy link
Collaborator Author

I would like to work on this.

@danishjamal104 danishjamal104 linked a pull request Nov 16, 2020 that will close this issue
Open
3 tasks
danishjamal104 added a commit to danishjamal104/android-client that referenced this issue Nov 16, 2020
@danishjamal104
Added internet connectivity check before loading client info
5ced72c 
 Fix openMF#1559 - fixed toast message in client info page
danishjamal104 added a commit to danishjamal104/android-client that referenced this issue Nov 16, 2020
@danishjamal104
Added internet connectivity check before loading client info
8a90109 
 Fix openMF#1559 - fixed toast message in client info page

inflateClientInformation() method modifiede in clientDetailsFragment.java to meet the cheecklist
danishjamal104 added a commit to danishjamal104/android-client that referenced this issue Nov 17, 2020
@danishjamal104
Added internet connectivity check before loading client info
afcd23a 
 Fix openMF#1559 - fixed toast message in client info page

inflateClientInformation() method modifiede in clientDetailsFragment.java to meet the cheecklist

Extracted string resource while displaying error toast. Also added language conversion of the same
@kmanikanta335
Copy link

i am working on this issues

@kmanikanta335 kmanikanta335 linked a pull request Nov 2, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue
Projects
None yet
Milestone
No milestone
3 participants
@danishjamal104 @Aditya-gupta99 @kmanikanta335