Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing whitespace in many translatable strings #3480

Open
Nikerabbit opened this issue Jun 15, 2022 · 0 comments
Open

Trailing whitespace in many translatable strings #3480

Nikerabbit opened this issue Jun 15, 2022 · 0 comments

Comments

@Nikerabbit
Copy link

Description

I am reviewing list of messages whose definition differ in translatewiki.net and in the source code repo to ensure everything is in sync.

Everything seems okay, except the following list of messages which contain trailing whitespace (spaces or new lines). Trailing whitespace is not supported in translatewiki.net. It's always stripped when saving a translations.

The trailing whitespace should be removed from the message definitions. In case it is significant and affects rendering or display of text, it should be added by the code instead. Do note that all such messages are currently broken when translated.

Do note that whitespace in the beginning is supported, but if it is not significant, it should be removed too to avoid confusing translators. We don't validate that the whitespace is preserved in translations.

Mifos:X-label.heading.glimloanAccountNo/en
' GLIM Account No '                    | ' GLIM Account No'                    

Mifos:X-label.button.staffassignmenthistory/en
'Staff Assignment History '            | 'Staff Assignment History'            

Mifos:X-label.relDate/en
'Mifos X Release Date: '               | 'Mifos X Release Date:'               

Mifos:X-label.relVersion/en
'Release Version: '                    | 'Release Version:'                    

Mifos:X-validation.msg.invalid.month.day/en
'`{{params[0].value}}` is an invalid   | '`{{params[0].value}}` is an invalid  
month day. '                           | month day.'                           

Mifos:X-error.msg.groups.bulk.client.transfers.to.different.office/en
'Bulk Transfers of clients between     | 'Bulk Transfers of clients between    
Groups in different branches are not   | Groups in different branches are not  
allowed '                              | allowed'                              

Mifos:X-error.msg.client.transfers.destination.group.absent/en
'Destination Group for transfer of     | 'Destination Group for transfer of    
clients originally linked to a group   | clients originally linked to a group  
is not selected '                      | is not selected'                      

Mifos:X-error.msg.client.transfers.with.multiple.group.linkages/en
'Transfer of clients linked to         | 'Transfer of clients linked to        
multiple groups is not supported  '    | multiple groups is not supported'     

Mifos:X-error.msg.loan.submittal.cannot.be.before.client.transfer.date/en
' The date on which the loan is        | ' The date on which the loan is       
submitted cannot be earlier than       | submitted cannot be earlier than      
client's transfer date of              | client's transfer date of             
({{params[0].value}}) '                | ({{params[0].value}})'                

Mifos:X-error.msg.loan.approval.cannot.be.before.client.transfer.date/en
' The date on which the loan is        | ' The date on which the loan is       
approved cannot be earlier than        | approved cannot be earlier than       
client's transfer date of              | client's transfer date of             
({{params[0].value}}) '                | ({{params[0].value}})' 

Mifos:X-error.msg.loan.approval.cannot.be.undone.before.client.transfer.date/en
' The date on which the loan is        | ' The date on which the loan is       
approved cannot be earlier than        | approved cannot be earlier than       
client's transfer date of              | client's transfer date of             
({{params[0].value}}) '                | ({{params[0].value}})'                

Mifos:X-error.msg.loan.disbursal.cannot.be.before.client.transfer.date/en
' The date on which the loan is        | ' The date on which the loan is       
disbursed cannot be earlier than       | disbursed cannot be earlier than      
client's transfer date of              | client's transfer date of             
({{params[0].value}}) '                | ({{params[0].value}})'                

Mifos:X-error.msg.loan.repayment.or.waiver.cannot.be.made.before.client.transfer.date/en
' Cannot make (or edit) repayments and | ' Cannot make (or edit) repayments and
waivers prior to client's transfer     | waivers prior to client's transfer    
date of ({{params[0].value}})  '       | date of ({{params[0].value}})'        

Mifos:X-error.msg.loan.reject.cannot.be.before.client.transfer.date/en
' The date on which the loan is        | ' The date on which the loan is       
rejected cannot be earlier than        | rejected cannot be earlier than       
client's transfer date of              | client's transfer date of             
({{params[0].value}}) '                | ({{params[0].value}})'                

Mifos:X-error.msg.loan.withdraw.cannot.be.before.client.transfer.date/en
' The date on which the loan is        | ' The date on which the loan is       
withdrawn cannot be earlier than       | withdrawn cannot be earlier than      
client's transfer date of              | client's transfer date of             
({{params[0].value}}) '                | ({{params[0].value}})'                

Mifos:X-error.msg.loan.writeoff.cannot.be.undone.before.client.transfer.date/en
' The date on which a write off is     | ' The date on which a write off is    
made cannot be earlier than client's   | made cannot be earlier than client's  
transfer date of ({{params[0].value}}) | transfer date of                      
'                                      | ({{params[0].value}})'                

Mifos:X-error.msg.loan.close.cannot.be.undone.before.client.transfer.date/en
' The date on which the loan is repaid | ' The date on which the loan is repaid
in full cannot be earlier than         | in full cannot be earlier than        
client's transfer date of              | client's transfer date of             
({{params[0].value}}) '                | ({{params[0].value}})'                

Mifos:X-validation.msg.client.active.pending.status.not.allowed/en
'Configuration does not allow a client | 'Configuration does not allow a client
to be created as `Pending`. '          | to be created as `Pending`.'          

Mifos:X-error.msg.group.members.count.must.be.in.permissible.range/en
'This action caused a group Validation | 'This action caused a group Validation
Error: Number of Clients must be       | Error: Number of Clients must be      
between `{{params[1].value}}` and      | between `{{params[1].value}}` and     
`{{params[2].value}}` '                | `{{params[2].value}}`'                

Mifos:X-label.heading.graceoninterestpayment/en
'Grace: On Interest Payment '          | 'Grace: On Interest Payment'          

Mifos:X-label.tooltip.numberofdays/en
'A loan is in arrears once the number  | 'A loan is in arrears once the number 
of days entered into this field is     | of days entered into this field is    
exceeded. If this field is blank, the  | exceeded. If this field is blank, the 
loan will be in arrears the day after  | loan will be in arrears the day after 
a scheduled payment is missed. '       | a scheduled payment is missed.'       

Mifos:X-label.tooltip.interest/en
'The Interest method value is input to | 'The Interest method value is input to
calculating the payments amount for    | calculating the payments amount for   
repayment of the loan. '               | repayment of the loan.'               

Mifos:X-label.tooltip.csi.amount/en
'The amount field must be filled in if | 'The amount field must be filled in if
the Standing Instruction Type is       | the Standing Instruction Type is      
Fixed. It must be blank if the         | Fixed. It must be blank if the        
Standing Instruction Type is Dues. '   | Standing Instruction Type is Dues.'   

Mifos:X-error.msg.loan.transaction.is.not.a.overpaid.loan=20/en
'Transfer funds is allowed only for    | 'Transfer funds is allowed only for   
loan accounts with overpaid status '   | loan accounts with overpaid status'

Mifos:X-validation.msg.savingsaccount.delete.transaction.invalid.account.is.closed/en
'Charge cannot be deleted as account   | 'Charge cannot be deleted as account  
is closed. '                           | is closed.'                           

Mifos:X-validation.msg.savingsaccount.cannot.add.activation.charge.savings.account.status.not.valid/en
'Activation time charge cannot be      | 'Activation time charge cannot be     
added to account. Account status       | added to account. Account status      
should be submitted and pending        | should be submitted and pending       
approval or approved and not           | approval or approved and not          
activated.  '                          | activated.'                           

Mifos:X-error.msg.codeValue.in.use/en
'This code value is in use '           | 'This code value is in use'           

Mifos:X-validation.msg.hook.required.config.field.not.provided/en
'`{{params[0].value}}` configuration   | '`{{params[0].value}}` configuration  
field is not provided. '               | field is not provided.'               

Mifos:X-label.heading.interestRateCycleVariations/en
'Nominal Interest Rate by loan cycle ' | 'Nominal Interest Rate by loan cycle' 

Mifos:X-label.heading.numerOfRepaymentCycleVariations/en
'Number of Repayments by loan cycle '  | 'Number of Repayments by loan cycle'  

Mifos:X-label.input.mandatory.guarantee/en
'Mandatory Guarantee: (%) '            | 'Mandatory Guarantee: (%)'            

Mifos:X-label.input.minimum.guarantee.from.own.funds/en
'Minimum Guarantee from Own Funds: (%) | 'Minimum Guarantee from Own Funds:    
'                                      | (%)'                                  

Mifos:X-validation.msg.charge.amount.not.greater.than.zero/en
'Charge amount must be greater than    | 'Charge amount must be greater than   
zero. '                                | zero.'                                

Mifos:X-validation.msg.charges.savings.charge.calculation.type.percentage.allowed.only.for.withdrawal/en
'Savings charges with charge           | 'Savings charges with charge          
calculation type as percentage is      | calculation type as percentage is     
allowed only for Withdrawal fee. '     | allowed only for Withdrawal fee.'     

Mifos:X-validation.msg.charges.charge.calculation.type.percentage.allowed.only.for.withdrawal/en
'Savings charges with charge           | 'Savings charges with charge          
calculation type as percentage is      | calculation type as percentage is     
allowed only for Withdrawal fee. '     | allowed only for Withdrawal fee.'     

Mifos:X-validation.msg.fixeddeposit.chart.slabs.period.range.end.incorrect/en
'Period range  must end as open for    | 'Period range  must end as open for   
interest rate chart '                  | interest rate chart'                  

Mifos:X-validation.msg.loanproduct.interestType.not.equal.to.specified.number/en
'Flat interest type is not allowed for | 'Flat interest type is not allowed for
multi disburse loan '                  | multi disburse loan'                  

Mifos:X-validation.msg.loan.interestType.not.equal.to.specified.number/en
'Flat interest type is not allowed for | 'Flat interest type is not allowed for
multi disburse loan '                  | multi disburse loan'                  

Mifos:X-error.msg.charge.must.be.penalty/en
'Overdue Charge must be a penalty '    | 'Overdue Charge must be a penalty'    

Mifos:X-label.view.paymentTypes/en
'Manage payment types '                | 'Manage payment types'                

Mifos:X-label.heading.nodataavailablefor/en
'No Data Available For '               | 'No Data Available For'               

Mifos:X-label.heading.onmeetingdate/en
'on meeting date : '                   | 'on meeting date :'                   

Mifos:X-error.msg.survey.duplicate.key/en
'Survey is already exist with key :    | 'Survey is already exist with key :   
`{{params[0].value}}` '                | `{{params[0].value}}`'                

Mifos:X-----End---/en
'--End of file--- '                    | '--End of file---'  
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant