Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

20-files-present-and-referenced is not run locally like in OBS #91

Open
AdamMajer opened this issue Feb 25, 2021 · 1 comment
Open

20-files-present-and-referenced is not run locally like in OBS #91

AdamMajer opened this issue Feb 25, 2021 · 1 comment

Comments

@AdamMajer
Copy link
Member

obs-service-source_validator/20-files-present-and-referenced

Line 156 in 4816aee

if ! test -f "$DIR_TO_CHECK/_service"; then

Because of this simple check, the sources check is not run locally when _service file is present while it's still run in OBS. Why do we need this?
@AdamMajer
Copy link
Member Author

I understand this is for server side services. But when only manual or disabled _service is present, then the check is also skipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AdamMajer