Main #2281
Open
Main #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added try-except block in log_mel_spectrogram to catch and print errors. - Enhanced docstrings for load_audio, pad_or_trim, mel_filters, and log_mel_spectrogram functions.
- Implemented per-token confidence tracking in GreedyDecoder and BeamSearchDecoder. - Updated DecodingResult to include tokens_probs. - Enhanced token update methods to calculate and store token probabilities. - Improved finalization methods to handle token probabilities. - Modified DecodingTask to manage per-token confidence during the decoding process.
linsen20220222
pushed a commit
to zebra-media/whisper
that referenced
this pull request
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request addresses several issues to improve the robustness and documentation of the
audio.pyfile.Changes
Error Handling:
log_mel_spectrogramfunction to catch and print errors.Improved Documentation:
load_audio,pad_or_trim,mel_filters, andlog_mel_spectrogramfunctions for better clarity.Related Issues
log_mel_spectrogramfunction.Testing
All existing tests pass. Additional tests can be added to verify the new error handling.