Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery TAP support #172

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

dspeck1
Copy link

@dspeck1 dspeck1 commented Sep 5, 2024

Add tap support for BigQuery. Includes the geometric conversions from TAP to BigQuery geometric functions. The TAP server example for running this will be provided in a different repository.

@dspeck1 dspeck1 changed the title BigQuery TAP support. BigQuery TAP support Sep 5, 2024
@pdowler
Copy link
Member

pdowler commented Sep 5, 2024

Can you also add this to the .github/workflows/gradle.yml?

Below cadc-tap-server-oracle (which I just fixed so you will need to pull main) and in that same style.

We haven't got to it yet in tap.git (technical debt), but in many repos we also run the checkstyleMain target in CI so if checkstyle passes for your code you can add that and the PR looks even better. Something like this:

    - name: build and test cadc-tap-server-bigquery
      run: cd cadc-tap-server-bigquery && ../gradlew --info clean build javadoc checkstyleMain install

Copy link
Member

@pdowler pdowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments on the build

cadc-tap-server-bigquery/build.gradle Outdated Show resolved Hide resolved
cadc-tap-server-bigquery/build.gradle Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants