From 1f5c2a86e2c7f5f1e38ababa635d83d0fc18e045 Mon Sep 17 00:00:00 2001 From: Krisztian Gacsal Date: Wed, 14 Feb 2024 15:35:26 +0100 Subject: [PATCH] ci: fix success check The success is skipped instead of failed when depending jobs defined in needs parameter are skipped/failed. Skipped success job threated the same way as if it was successful therefore CI proceeds with merging PRs in case auto-merge is enabled. --- .github/workflows/ci.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 38c2bfa5e..288677fd0 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -89,6 +89,9 @@ jobs: use_release_repository: false success: + # https://github.com/actions/runner/issues/2566 + # https://github.com/actions/toolkit/issues/581 + if: ${{ !cancelled() && !contains(needs.*.result, 'cancelled') && !contains(needs.*.result, 'failure') }} needs: - build - e2e