Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatting issues/loosen ruff rules #67

Open
jramosss opened this issue Jul 3, 2024 · 4 comments
Open

Fix formatting issues/loosen ruff rules #67

jramosss opened this issue Jul 3, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@jramosss
Copy link

jramosss commented Jul 3, 2024

CI is failing because of the formatting, see
We should both loose the rules and fix previous errors
@jramosss jramosss added the enhancement New feature or request label Jul 3, 2024
@jramosss jramosss mentioned this issue Jul 3, 2024
Open
@peterdudfield
Copy link
Contributor

Thank you @jramosss for doing this

@peterdudfield
Copy link
Contributor

im not sure we should loosen the rules. I wonder what is standard when releasing these models?

@jramosss
Copy link
Author

jramosss commented Jul 6, 2024

It depends, i'm just thinking maybe marking docstrings as required for every function is a bit extreme for example

@peterdudfield
Copy link
Contributor

It depends, i'm just thinking maybe marking docstrings as required for every function is a bit extreme for example

how would you suggest loosening the rules?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peterdudfield @jramosss