Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update solar limit to 5000 (from 4000) #509

Open
peterdudfield opened this issue Apr 29, 2024 · 4 comments
Open

Update solar limit to 5000 (from 4000) #509

peterdudfield opened this issue Apr 29, 2024 · 4 comments
Assignees

Comments

@peterdudfield
Copy link
Contributor

Currently the solar generation was very near 4000, and the graph look a bit close to the top.
We could adjust the yaxis to something a bit

Here sets out a few examples of how to do it

https://stackoverflow.com/questions/50078787/recharts-set-y-axis-range

@peterdudfield
Copy link
Contributor Author

peterdudfield commented Apr 29, 2024

One way to do this is with padding={{ top: 20 }}.

If we use <YAxis type="number" domain={[0, 20000]}/> I think we will always run into issues for different data at different order of magnitudes.

Screenshot 2024-04-29 at 16 39 17

@peterdudfield
Copy link
Contributor Author

@braddf I can make a PR, but wanted to get your opinion on domain or padding or other things in https://recharts.org/en-US/api/YAxis

@braddf
Copy link
Contributor

braddf commented Apr 30, 2024

@peterdudfield just looking at this now, my first impression is that padding is just the gap and I don't think it looks as nice

@peterdudfield
Copy link
Contributor Author

peterdudfield commented Apr 30, 2024

Yea I know what you mean. I thought it would be an empty space of padding, but it looks like its padding on the Yaxis, so its maybe a bit like a buffer ontop of the maximum value.

its this bit, above 4000

Screenshot 2024-04-30 at 08 32 39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants