Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm un-used apps #514

Merged
merged 10 commits into from
Jul 12, 2024
Merged

rm un-used apps #514

merged 10 commits into from
Jul 12, 2024

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented May 13, 2024

Pull Request

Description

remove website and ui-ux demos

How Has This Been Tested?

  • CI tests,

  • not tested, but these will be in git history

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nowcasting-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2024 10:07am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
quartz-app ⬜️ Ignored (Inspect) Jul 12, 2024 10:07am

@peterdudfield peterdudfield requested a review from braddf May 13, 2024 08:18
Copy link
Contributor

@braddf braddf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, should really test the main apps both build locally in case they have any funny dependencies on these (the build will now skip if the files in those apps haven't changed)

Also could you change the target branch to development to go through proper flow 👍

@peterdudfield peterdudfield changed the base branch from main to development May 14, 2024 11:26
@peterdudfield
Copy link
Contributor Author

Looks fine, should really test the main apps both build locally in case they have any funny dependencies on these (the build will now skip if the files in those apps haven't changed)

Also could you change the target branch to development to go through proper flow 👍

Do you want me to test them locally? Or you happy with the small risk of this?

@peterdudfield
Copy link
Contributor Author

@braddf you happy for this to merge?

@peterdudfield peterdudfield mentioned this pull request Jul 10, 2024
6 tasks
@peterdudfield peterdudfield merged commit 8a376c5 into development Jul 12, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants