Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quartz Solar v0.5.2 – Staging #536

Merged
merged 35 commits into from
Sep 4, 2024
Merged

Quartz Solar v0.5.2 – Staging #536

merged 35 commits into from
Sep 4, 2024

Conversation

braddf
Copy link
Contributor

@braddf braddf commented Sep 2, 2024

Pull Request

Description

Includes a bundle of UI/UX improvements and features for the Quartz Solar UK UI.

  • πŸ•‘ N-hour forecast, replacing 4hr forecast functionality with a dropdown to switch forecast horizon;
  • πŸ“ˆ Chart legend – simplify + add toggles;
  • πŸ“ˆ Fix responsiveness for different screen sizes large and small (within reason, not beautiful on mobile but it should roughly work now at least);
  • πŸ“ˆ National full height charts when GSP not selected;
  • πŸ“ˆ Disable untidy chart animations;
  • πŸ”½ Tidy Delta view table/layout;
  • 0️⃣ Sites empty / welcome state;
  • πŸ—ΊοΈ PV Forecast map tooltip, showing actuals/capacities/forecast values, and dynamic to the map mode;
  • ⭐ Correct/nicer page title in browser tab

Fixes #

How Has This Been Tested?

  • Cypress tests running (and caught an issue with the profile dropdown I had inadvertently caused, before I had committed! Good job, tests πŸ™Œ )
  • Locally and on Dev

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

  • Yes, some tweaks to map functionality and all seems okay to me

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@braddf braddf added the release label Sep 2, 2024
@braddf braddf requested a review from peterdudfield September 2, 2024 15:51
@braddf braddf self-assigned this Sep 2, 2024
Copy link

vercel bot commented Sep 2, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
nowcasting-app βœ… Ready (Inspect) Visit Preview πŸ’¬ 4 unresolved
βœ… 19 resolved
Sep 4, 2024 4:02pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
quartz-app ⬜️ Ignored (Inspect) Visit Preview Sep 4, 2024 4:02pm

Copy link
Contributor

@peterdudfield peterdudfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, and loads of things in it. In general it feels a big PR.

Ive put a few minor comments them, perhaps the biggest being NHour or NHr. Some of the of the comments are questions, so feel free to dismiss them as you see fit

@braddf braddf merged commit 84644c3 into staging Sep 4, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants