Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Quartz Solar v0.5.3 – Production #547

Merged
merged 10 commits into from
Nov 13, 2024
Merged

🚀 Quartz Solar v0.5.3 – Production #547

merged 10 commits into from
Nov 13, 2024

Conversation

braddf
Copy link
Contributor

@braddf braddf commented Nov 12, 2024 •
edited
Loading

Pull Request

Description

Patch Release – small fixes

Fix for squished chart layout on Sites view and neaten up the scrollbar situation for mouse users.

Fixes #541

N.B. the Node CI is still not working, changes in here were unsuccessful but getting closer – need more time to figure out how to get those tests to run properly, but is no more broken than it was and doesn't affect the deploy itself.

How Has This Been Tested?

  • Locally, on Vercel preview branches [dev / staging] on Mac/Windows using Chrome/Firefox
  • UAT (below)

UAT

Probabilistic Charts

  • Shading appears around the lines.
  • Plevel values in the tooltip are 0.0 or above.
  • Probabilistic range shading and tooltip values appear on the DeltaView charts.

Quartz-specific points

  • Does the logo look like the new Quartz logo?
  • Does the logo link to the new Quartz website?
  • Is the OCF logo present in the logo area?
  • Does the OCF logo link to the OCF website?
  • Does the Documentation link go to the new Quartz docs?

PV Forecast

National

  • Does PV live estimate show on the plot? (black dashed)
  • Does PV live updated show on the plot? (black solid)
  • Does OCF forecast show up on plot? (yellow)
  • For OCF forecast, is the future a dashed line?
  • Can I hover on the plot to show the values on the plot?
  • Does the data look like solar profiles?
  • Clicking on a GSP makes the GSP plot show up?
  • Clicking on a GSP when already selected, makes the GSP plot go away?
  • Can I click on a time in the national plot which then updates the map?
  • Can I click on a past time in the GSP plot which then updates the map?
  • Can I click on a future time in the GSP plot which then updates the map?
  • Are values higher on the map in the middle of the day, compared to early morning?

Time

  • Is time now in Europe London time? It should be to the nearest 30 minute, rounded up.
  • Is the hover time in Europe London time?
  • Are the X axis in Europe London time?
  • Does the data show yesterday as well?
  • Does the data show tomorrow as well?

Header

  • Is this the title clear it is National data?
  • Does the headline current estimated PV figure display?
  • Does it show the current Forecasted value?
  • Does the next forecast figure display?
  • Are the units GW?

GSP

  • Does PV live estimate show on the plot? (dashed black)
  • Does PV live updated show on the plot? (solid black)
  • Does OCF forecast show up on plot? (yellow)
  • For OCF forecast, is the future a dashed line?
  • Can I hover on the plot to show the values on the plot?
  • Does the data look like solar profiles?

Time

  • Is time now in Europe London time?
  • Is the hover time in Europe London time?
  • Are the X axis in Europe London time?

Title

  • Does the GSP name show up?
  • Is the current estimated PV visible?
  • Is the next forecast figure visible?
  • Are the above figures in MW?

Map

  • Does a map of the UK show up?
  • Are the GSP boundaries displayed?
  • Can I click on '%', 'MW' and 'Capacity'
  • on 'Capacity' view, is there very little power in Scotland, and Melksham a shining beacon of renewables?

N Hour View

National

  • Does the "N-hour forecast" toggle show in the Profile Dropdown menu?
  • Toggle on
    • Does the Nhr forecast show up on the plot? (orange)
    • Does the Nhr future forecast show up on the plot? (dashed orange)
    • Does the Nhr forecast not show on the chart or tooltip when switched off?
  • Toggle off
    • Does the Nhr forecast not show on the chart or tooltip when switched off?
    • Does the Nhr future forecast not show on the chart or tooltip when switched off?
  • Does the Nhr forecast toggle persist across refreshes/logouts using cookie?

**** See comment below

  • Do the Nhr forecast values show in the hover tooltip?

Delta View

National

  • Does PV live estimate show on the plot? (black dashed)
  • Does PV live updated show on the plot? (black solid)
  • Does OCF forecast show up on plot? (yellow)
  • For OCF forecast, is the future a dashed line?
  • Does the N-hour forecast not show on the chart or tooltip when switched off?
  • Does the N-hour forecast dropdown switcher not show in the legend when switched off?
  • Does the N-hour future forecast not show on the chart or tooltip when switched off?
  • Does the N-hour forecast show on the chart and tooltip when switched on?
  • Does the N-hour forecast dropdown switcher show in the legend when switched on? see comment below
  • Can I hover on the plot to show the values on the plot?
  • Does the data look like solar profiles?
  • Clicking on a GSP makes the GSP plot show up?
  • Clicking on a GSP when already selected, makes the GSP plot go away?
  • Can I click on a time in the national plot which then updates the map?
  • Can I click on a time in the GSP plot which then updates the map?
  • Are values higher on the map in the middle of the day, compare to early morning?

Time

  • Is time now in Europe London time? It should be 30minute, but rounded up.
  • Is the hover time in Europe London time?
  • Are the X axis in Europe London time?
  • Does the data show yesterday as well?

Header

  • Is this the title clear it is National data?
  • Does the headline current estimated PV figure display?
  • Does it show the current Forecasted value?
  • Does the next forecast figure display?
  • Are the units GW?

GSP

  • Does PV live estimate show on the plot? (dashed black)
  • Does PV live updated show on the plot? (solid black)
  • Does OCF forecast show up on plot? (yellow)
  • For OCF forecast, is the future a dashed line?
  • Can I hover on the plot to show the values on the plot?
  • Does the data look like solar profiles?

Time

  • Is time now in Europe London time?
  • Is the hover time in Europe London time?
  • Are the X axis in Europe London time?

Title

  • Does the GSP name show up?
  • Is the latest forecast figure visible?
  • Is the current GSP delta figure visible?
  • Are the above figures in MW?
  • Is the Delta block background colour correct, i.e. pos/neg delta colour scheme?

Map

  • Does a map of the UK show up?
  • Are the GSP boundaries displayed?
  • Where Deltas are available, do the correct colours for the GSP delta buckets display and match the table?

Combined views

  • Does selectedGSP persist when switching between PV Forecast and Delta Views
  • Does selectedTime persist when switching between PV Forecast and Delta Views
  • Does map location/zoom persist when switching between PV Forecast and Delta Views

Dashboard Mode

  • Does the Dashboard Mode toggle show in the Profile Dropdown menu?
  • Does the Dashboard Mode toggle persist across refreshes/logouts using cookie?

National

  • Do the National title and forecast values show in large font? See comment below
  • Are the lines on the chart thicker?

GSP

  • Do the GSP title and forecast values show in large font?
  • Are the lines on the chart thicker?

Legend

  • Is the legend larger?
  • Do the legend items space nicely?

Map

  • Is the map legend larger?
  • Are the MW/%/Capacity buttons larger?
  • Are the date/time larger?

General

  • is the version visible?
  • has the version been bumped?
  • Does the feedback button work?
  • Is the legend visible
  • Is the database stable, check on AWS

Auth

  • Can I log on with Auth?
  • Can i log out?

Refresh

  • After 10 mins, does the forecast update?

Documentation

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@braddf braddf added the release label Nov 12, 2024
@braddf braddf self-assigned this Nov 12, 2024
@vercel Vercel
Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nowcasting-app ✅ Ready (Inspect) Visit Preview 💬 2 unresolved
✅ 1 resolved		 Nov 12, 2024 4:20pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
quartz-app ⬜️ Ignored (Inspect) Nov 12, 2024 4:20pm

@braddf braddf merged commit ff59fb6 into main Nov 13, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterdudfield peterdudfield peterdudfield approved these changes

Assignees

@braddf braddf

Labels
release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quartz Solar – Sites view charts responsive/squished when table too long
2 participants
@braddf @peterdudfield