Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add macOS builds to CI #1496

Open
ryandesign opened this issue Apr 20, 2024 · 0 comments · May be fixed by #1511
Open

Add macOS builds to CI #1496

ryandesign opened this issue Apr 20, 2024 · 0 comments · May be fixed by #1511

Comments

@ryandesign
Copy link
Contributor

Looking through the ChangeLog and NEWS files, I saw a few cases where new releases had to be made because the previous one would not build on macOS, and I am not able to build the current version on macOS. The occurrence of releasing versions that cannot be built on macOS might be reduced by adding macOS builds to your continuous integration. I plan to send a PR to do this, after I can get it building on my local machine, so this issue is just a reminder to myself and also a request for comments.
@ryandesign ryandesign linked a pull request Apr 24, 2024 that will close this issue
Open
ryandesign added a commit to ryandesign/link-grammar that referenced this issue Apr 24, 2024
@ryandesign
Add macOS CI
590844b 
Also do CI testing on macOS 12, 13, and 14. Not using "macos-latest"
because that currently refers to macOS 12 which is not the latest
version. It is good to test on multiple versions and on multiple
architectures. The macOS 12 and 13 runners are x86_64 while the macOS 14
runner is arm64. This list can be updated annually as new macOS versions
are released and old versions are removed from CI, or switched to
"macos-latest" once that actually points to the latest version again.

Do not fail fast; this ensures that a build failure on one runner does
not cancel the other runners so that temporarily expected failures on
one runner do not mask unexpected failures on other runners.

Use Homebrew (pre-installed on macOS runners) to install dependencies
for macOS.

Explicitly mention dependencies that are used, like autoconf, automake,
and libtool, even if they are in the set of dependencies already
pre-installed on the runners, because who knows if that will always be
the case.

Fixes opencog#1496
ryandesign added a commit to ryandesign/link-grammar that referenced this issue Apr 25, 2024
@ryandesign
Add macOS CI
6537f9e 
Also do CI testing on macOS 12, 13, and 14. Not using "macos-latest"
because that currently refers to macOS 12 which is not the latest
version. It is good to test on multiple versions and on multiple
architectures. The macOS 12 and 13 runners are x86_64 while the macOS 14
runner is arm64. This list can be updated annually as new macOS versions
are released and old versions are removed from CI, or switched to
"macos-latest" once that actually points to the latest version again.

Do not fail fast; this ensures that a build failure on one runner does
not cancel the other runners so that temporarily expected failures on
one runner do not mask unexpected failures on other runners.

Use Homebrew (pre-installed on macOS runners) to install dependencies
for macOS.

Explicitly mention dependencies that are used, like autoconf, automake,
and libtool, even if they are in the set of dependencies already
pre-installed on the runners, because who knows if that will always be
the case.

Fixes opencog#1496
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI improvements: add macOS runners; build in parallel; disable silent rules ryandesign/link-grammar
1 participant
@ryandesign