Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect creation of _det dependency relation #230

Open
williampma opened this issue Nov 6, 2015 · 9 comments
Open

Incorrect creation of _det dependency relation #230

williampma opened this issue Nov 6, 2015 · 9 comments
Labels

Comments

@williampma
Copy link
Member

_det is triggered incorrectly.

Link Grammar parse diagram:

    +---------------Xp--------------+       
    +-------->WV-------->+          |       
    +-----Wd-----+       |          |       
    |      +Ds**v+---Ss--+-Paf-+    +--RW--+
    |      |     |       |     |    |      |
LEFT-WALL an Italian.s is.v crazy.a . RIGHT-WALL 


Phrase Structure parse:

    (S (NP an Italian.s) (VP is.v (ADJP crazy.a)) .)

Dependency relations:

    _det(Italian, an)
    _predadj(Italian, crazy)

Attributes:

    penn-POS(be, VBZ)
    subscript-TAG(be, .v)
    pos(be, verb)
    tense(crazy, present)
    penn-POS(crazy, JJ)
    subscript-TAG(crazy, .a)
    pos(crazy, adj)
    definite-FLAG(Italian, T)
    penn-POS(Italian, NN)
    subscript-TAG(Italian, .s)
    pos(Italian, noun)
    noun_number(Italian, singular)
    penn-POS(an, DT)
    pos(an, det)
    pos(., punctuation)

A bit related to #211 and #212 no doubt.

@williampma williampma added the bug label Nov 6, 2015
@williampma williampma changed the title Incorrect _det dependency relation Incorrect creation of _det dependency relation Nov 6, 2015
@linas
Copy link
Member

linas commented Nov 6, 2015

? what's the problem? the output looks right to me ... what were you expecting?

@williampma
Copy link
Member Author

Expecting no _det(Italian, an).

_det is not generated for sentences like "An orange is tasty.". So it's something different for this sentence An Italian is crazy in particular.

R2L uses _det only for "those", "these", "this", "that". Unless R2L is also wrong.

@linas
Copy link
Member

linas commented Nov 6, 2015

_det should be generated for "An orange is tasty." and any other sentence with a, an, the, this, these, those ... Not sure what R2L has to do with this?

@williampma
Copy link
Member Author

Just that one of the R2L rule accept the _det relation.

If _det is supposed to be for a, an, the as well, then the R2L is bugged.

@linas
Copy link
Member

linas commented Nov 6, 2015

!? Well, a determiner is a determiner. For dis-embodied text, determiners offer little information, and its possible that relex tried to avoid generating them. However, for embodied chat, being able to understand determiners is critical.

BTW, it turns out that depressed people use determiners much more often, its even a sign of suicidality: instead of saying "the book is on top of the table", they will say "this is on top of that", as if unable to fully delineate the objects being talked about.

@amebel
Copy link
Contributor

amebel commented Nov 6, 2015

why put the effort if one is planning to die? that is rational 😆

@anitzkin
Copy link
Contributor

anitzkin commented Nov 6, 2015

Lol. Perhaps it reflects a lackof caring about specifics? I mean if you're depressed, who cares what's on top of what? It's all the same?

About _det . . .. as I recall, and I am not sure I recall correctly, when I found it, it was being used only for this, that, those, and these, which of course really annoyed me, because not only are those not the only determiners, but they are also demonstratives, which require special treatment; they call on an R2L scheme helper which creates a variable to express the fact that they should induce the system to identify "which" referent they are pointing at. Which is all well and good, but not consistently integrated with the treatment of other determiners, which as far as I know only trigger the tag "indefinite" or "definite" to be attached to the node for the noun in question.

I believe (but I'm not sure I remember correctly) that I partially revised that aspect of relex / R2L, and then we rolled back the revisions because I had broken the treatment of "this" "that" etc. and then the whole issue was left hanging. Probably someone needs to proceed with generalizing _det for all determiners, and creating an additional relation for "demonstrativeness."

@anitzkin
Copy link
Contributor

anitzkin commented Nov 6, 2015

Sorry, if that wasn't clear; yes, R2Lis bugged. Because the only R2L _det rule, if things haven't changed, is the one that assigns variables to demonstrative determiner phrases.

I'm going to see if I can get a VMware opencog running on my laptop so I can do some relex / r2l work, as I am still uneployed at the moment :-) . . . .

@linas
Copy link
Member

linas commented Nov 8, 2015

ahh, yes right ... if I recall correctly, a fuller support for _det is in the stanford compatibility files, and yes, originally, LG just stuck a definite/indefinite tag on the nouns. So to get stronger support for _det, you'd need to move it over from the stanford-compat files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants