Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing prefixes in GNSI modules "when paths" #1121

Open
marcusyuri opened this issue May 31, 2024 · 1 comment
Open

Missing prefixes in GNSI modules "when paths" #1121

marcusyuri opened this issue May 31, 2024 · 1 comment
Labels

Comments

@marcusyuri
Copy link

The are several missing prefixes in GNSI modules that generates path errors.

The following are the corrected paths:

--- a/release/models/gnsi/openconfig-gnsi-acctz.yang
+++ b/release/models/gnsi/openconfig-gnsi-acctz.yang
@@ -236,7 +236,8 @@ module openconfig-gnsi-acctz {

   // Augments section.
   augment "/oc-sys:system/oc-sys-grpc:grpc-servers/oc-sys-grpc:grpc-server" {
-    when "config[contains(services, 'oc-gnsi:GNSI')]/enable = 'true'";
+    when "oc-sys-grpc:config[contains(oc-sys-grpc:services, 'oc-gnsi:GNSI')]" +
+        "/oc-sys-grpc:enable = 'true'";
     description
       "Counters collected by the gNSI.acctz module.";

--- a/release/models/gnsi/openconfig-gnsi-authz.yang
+++ b/release/models/gnsi/openconfig-gnsi-authz.yang
@@ -202,7 +202,8 @@ module openconfig-gnsi-authz {
   }

   augment "/oc-sys:system/oc-sys-grpc:grpc-servers/oc-sys-grpc:grpc-server" {
-    when "config[contains(services, 'oc-gnsi:GNSI')]/enable = 'true'";
+    when "oc-sys-grpc:config[contains(oc-sys-grpc:services, 'oc-gnsi:GNSI')]" +
+        "/oc-sys-grpc:enable = 'true'";
     description
       "Counters collected while evaluating access to a gRPC server using
       the gNSI.authz authorization policy.";

--- a/release/models/gnsi/openconfig-gnsi-certz.yang
+++ b/release/models/gnsi/openconfig-gnsi-certz.yang
@@ -198,7 +198,8 @@ module openconfig-gnsi-certz {

   augment "/oc-sys:system/oc-sys-grpc:grpc-servers/oc-sys-grpc:grpc-server/" +
           "oc-sys-grpc:state" {
-    when "../config[contains(services, 'oc-gnsi:GNSI')]/enable = 'true'";
+    when "../oc-sys-grpc:config[contains(oc-sys-grpc:services, 'oc-gnsi:GNSI')]" +
+        "/oc-sys-grpc:enable = 'true'";
     description
       "A gRPC server credentials freshness information.";

@@ -207,7 +208,8 @@ module openconfig-gnsi-certz {

   augment "/oc-sys:system/oc-sys-grpc:grpc-servers/oc-sys-grpc:grpc-server/" +
           "oc-sys-grpc:state" {
-    when "../config[contains(services, 'oc-gnsi:GNSI')]/enable = 'true'";
+    when "../oc-sys-grpc:config[contains(oc-sys-grpc:services, 'oc-gnsi:GNSI')]" +
+        "/oc-sys-grpc:enable = 'true'";
     uses grpc-server-certz-counters;
     description
       "gNSI certz server access counters.";

--- a/release/models/gnsi/openconfig-gnsi-pathz.yang
+++ b/release/models/gnsi/openconfig-gnsi-pathz.yang
@@ -312,7 +312,8 @@ module openconfig-gnsi-pathz {
   }
   augment "/oc-sys:system/oc-sys-grpc:grpc-servers/oc-sys-grpc:grpc-server" +
           "/oc-sys-grpc:state" {
-    when "../config[contains(services, 'oc-gnsi:GNSI')]/enable = 'true'";
+    when "../oc-sys-grpc:config[contains(oc-sys-grpc:services, 'oc-gnsi:GNSI')]" +
+        "/oc-sys-grpc:enable = 'true'";
     description
       "A gNMI server OpenConfig-path-based authorization policy freshness
       information.";
Copy link

This issue is stale because it has been open 180 days with no activity. If you wish to keep this issue active, please remove the stale label or add a comment, otherwise will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

1 participant