Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how the density range of image was calculated #326

Open
emmaai opened this issue Jan 23, 2024 · 1 comment
Open

how the density range of image was calculated #326

emmaai opened this issue Jan 23, 2024 · 1 comment

Comments

@emmaai
Copy link

emmaai commented Jan 23, 2024

I'm not sure how the logic of this line works.

https://github.com/opendatacube/eo-datasets/blame/d5cf4a44b8ae3bbbe89cf026aa0e244a9badc8a3/eodatasets3/images.py#L1284

Shouldn't it get lowest of low and highest of high of all bands (e.g., rgb) instead?

atm, it caused trouble because I have three bands with different (min, max),

8 45
0 35
40 84

it gives the density range (40, 35), which doesn't make sense in the following function https://github.com/opendatacube/eo-datasets/blame/d5cf4a44b8ae3bbbe89cf026aa0e244a9badc8a3/eodatasets3/images.py#L1292

Is it a bug or something not supposed to be triggered?

@emmaai
Copy link
Author

emmaai commented Mar 1, 2024

The bug has happened since some version post 0.19.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant