Fix arithmetic division by zero in the DatasetTestReport API (#729)

opendatadiscovery · Jun 10, 2022 · acca082 · acca082
1 parent d9e3c91
commit acca082
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/...latform-api/src/main/java/org/opendatadiscovery/oddplatform/mapper/DataQualityMapper.java b/...latform-api/src/main/java/org/opendatadiscovery/oddplatform/mapper/DataQualityMapper.java
@@ -7,6 +7,9 @@
 
 @Mapper(config = MapperConfig.class, uses = OffsetDateTimeMapper.class)
 public interface DataQualityMapper {
-    @Mapping(target = "score", expression = "java( (int)(100 * report.getSuccessTotal() / report.getTotal()) )")
+    @Mapping(
+        target = "score",
+        expression = "java( report.getTotal() != 0 ? (int)(100 * report.getSuccessTotal() / report.getTotal()) : 0 )"
+    )
     DataSetTestReport mapDatasetTestReport(final DatasetTestReportDto report);
 }
diff --git a/odd-platform-api/src/main/resources/application.yml b/odd-platform-api/src/main/resources/application.yml
@@ -79,6 +79,8 @@ management:
   health:
     ldap:
       enabled: false
+    redis:
+      enabled: false
 
 logging:
   level:
-Original file line number
+Diff line change
@@ Expand Up / @@ -79,6 +79,8 @@ management: @@
       health:
         ldap:
           enabled: false
+        redis:
+          enabled: false
     logging:
       level:
@@ Expand Down @@