Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data science snippet includes packages like nvidia* that blow up image to 6GB even when no Torch or Cuda / GPU is needed #48

Open
shalberd opened this issue Nov 24, 2023 · 1 comment

Comments

@shalberd
Copy link

shalberd commented Nov 24, 2023

I noticed that with the latest addition of packages on October 25 to the bundle 2-datascience snippet, image size has increased, when using the regular base image, to 6B from 1.3 GB before.

Is that intended?

https://github.com/opendatahub-io-contrib/workbench-images/blob/main/snippets/bundles/2-datascience/py39/requirements.txt

I noticed that torch dependencies, nvidia stuff are all added during a normal image build.

I don't know, wondering whether for example the nvidia* packages could be added conditionally only in case torch or Tensorflow or Cuda or GPU is needed / selected?

@shalberd shalberd changed the title data science jupyter ide snippet includes packages like nvidia* that blow up image to 6GB even when no Torch or Cuda / GPU is needed data science snippet includes packages like nvidia* that blow up image to 6GB even when no Torch or Cuda / GPU is needed Nov 24, 2023
@shalberd
Copy link
Author

shalberd commented Dec 6, 2023

Ah, Codeflare, ok. Mmh, maybe a different bundle snippet instead of 2-datascience would be good for those cases ...
i.e. 10-codeflare or so ...

@guimou wrote:

Yeah, the issue comes from the codeflare sdk, which has dependencies on
pytorch, then nvidia...
For contrib I wanted to introduce codeflare in all the images, as well as
Elyra/kfp-tekton, but I'm not sure it's a good idea.
I talked to the Codeflare team, they were supposed to review their
dependencies, I did not check yet if they managed to have less heavy
dependencies.
So I guess it will come down to another discussion: which images should
include Codeflare sdk?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant