Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add seealso for oep58 in enable-translations-new-repo.rst #383

Closed
wants to merge 31 commits into from

Conversation

OmarIthawi
Copy link
Member

The seealso link will work after this branch is merged with main:

image

This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.

brian-smith-tcril and others added 30 commits August 2, 2023 17:44
…quirements-d4c5dfd

Python Requirements Update
Under the section, `Install Tutor Nightly` update the command `tutor dev quickstart` to `tutor dev launch` to configure and provision an Open edX instance. `quickstart` is not listed as one of the options commands for `tutor dev`.
Hade a single page that can serve as a hub for resources for
maintainers.  The content is still a part of the general developer space
but we're using a new special home page to collect the items that are
specifically relevant to maintainers so it's easier to find.
…quirements-095b8b9

Python Requirements Update
docs: Update 'install tutor nightly' command.
…quirements-d1960b7

Python Requirements Update
…cs-37348eb

fix: readthedocs file renamed
docs: use markdown for npm published READMEs
…quirements-e38849c

Python Requirements Update
…quirements-ede8833

Python Requirements Update
…quirements-149cc9f

Python Requirements Update
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 20, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@brian-smith-tcril
Copy link
Contributor

This diff looks huge, I think we should rebase oep-58-howto on latest main (or just merge main into oep-58-howto with the intention of getting oep-58-howto into main via squash+merge) and then see how it looks.

@OmarIthawi
Copy link
Member Author

This diff looks huge, I think we should rebase oep-58-howto on latest main (or just merge main into oep-58-howto with the intention of getting oep-58-howto into main via squash+merge) and then see how it looks.

Correct @brian-smith-tcril. It looks huge.

The GitHub makes the diff look confusing but it's pretty legit and shouldn't show up in #363.

However, I'm all in for updating oep-58-howto branch whether it's a rebase or a merge. Please update it so I can rebase this branch so it shows up cleanly in GitHub UI.

@brian-smith-tcril brian-smith-tcril deleted the branch openedx:oep-58-howto September 27, 2023 17:36
@openedx-webhooks
Copy link

@OmarIthawi Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@brian-smith-tcril
Copy link
Contributor

@OmarIthawi this was closed because I merged the oep-58-howto branch into main. Making a new PR to main is the ideal path forward here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants