Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Link content toast notification should not be displaying #1489

Open
jmakowski1123 opened this issue Nov 7, 2024 · 6 comments
Open

Bug: Link content toast notification should not be displaying #1489

jmakowski1123 opened this issue Nov 7, 2024 · 6 comments
Assignees
Labels
bug Report of or fix for something that isn't working as intended

Comments

@jmakowski1123
Copy link

The linked content toast notification should not be displaying when I create a new content block, either from library home or from the collection page.

Image

@jmakowski1123 jmakowski1123 converted this from a draft issue Nov 7, 2024
@bradenmacdonald
Copy link
Contributor

@navinkarkera The fix for #1435 seems to have introduced a regression that whenever a component is added to a library (e.g. add a Text component from the Library Home page), it shows a "Content linked successfully" toast. (Even when no collection is involved.)

Can you please look into that? And as mentioned above + on Slack we actually don't ever need that toast so it should be removed everywhere. It wasn't in the original specs for #1173

CC @rpenido

https://openedx.slack.com/archives/C06JG6RFE4V/p1731022665501119

@navinkarkera
Copy link
Contributor

@bradenmacdonald Got it. Created this PR: #1490 to fix it.

@navinkarkera navinkarkera moved this from Backlog to Ready for AC testing in Libraries Overhaul Nov 23, 2024
@navinkarkera
Copy link
Contributor

@jmakowski1123 @lizc577 @sdaitzman @marcotuts This is ready for AC testing on the sandbox

@sdaitzman
Copy link

I'm not seeing this, so looks good to me... were there any more specific situations that triggered it?

@navinkarkera
Copy link
Contributor

@sdaitzman No, it was just displayed when creating content from a collections page.

@pomegranited
Copy link
Contributor

@jmakowski1123 Is it okay to move it to Done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended
Projects
Status: Ready for AC testing
Development

No branches or pull requests

5 participants