-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Link content toast notification should not be displaying #1489
Comments
@navinkarkera The fix for #1435 seems to have introduced a regression that whenever a component is added to a library (e.g. add a Text component from the Library Home page), it shows a "Content linked successfully" toast. (Even when no collection is involved.) Can you please look into that? And as mentioned above + on Slack we actually don't ever need that toast so it should be removed everywhere. It wasn't in the original specs for #1173 CC @rpenido https://openedx.slack.com/archives/C06JG6RFE4V/p1731022665501119 |
@bradenmacdonald Got it. Created this PR: #1490 to fix it. |
@jmakowski1123 @lizc577 @sdaitzman @marcotuts This is ready for AC testing on the sandbox |
I'm not seeing this, so looks good to me... were there any more specific situations that triggered it? |
@sdaitzman No, it was just displayed when creating content from a collections page. |
@jmakowski1123 Is it okay to move it to Done? |
The linked content toast notification should not be displaying when I create a new content block, either from library home or from the collection page.
The text was updated successfully, but these errors were encountered: