chore: rebuilding the requirements with new constraint #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because this is consumed as a package, the requirements need to be built manually.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #150 +/- ##
=======================================
Coverage 99.78% 99.78%
=======================================
Files 11 11
Lines 461 461
Branches 33 33
=======================================
Hits 460 460
Partials 1 1 ☔ View full report in Codecov by Sentry. |
|
I think we still want to bump the version here too. |
deborahgu
commented
Jul 30, 2024
| def __init__(self): | ||
| self.args = sys.argv[1:] | ||
| self.configuration = None | ||
| self.parser = argparse.ArgumentParser() | ||
| self.parser.add_argument( |
There was a problem hiding this comment.
everything from here on down was just automatic lint.
|
|
||
| from setuptools import setup | ||
|
|
||
|
|
||
| def load_requirements(*requirements_paths): |
There was a problem hiding this comment.
taken from https://github.com/openedx/xblock-sdk/blob/master/setup.py. everything below this method is just linter.
justinhynes
approved these changes
Jul 30, 2024
bad typing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup.py has a
load_requirementsmethod which givesinstall_requiresa list of packages to install. The logic was not respecting constraints. However, we have modified this method elsewhere in the code base to respect constraints, so I updated accordingly.