From 82dadf9d595b53f5a6d90fe2b81f4d007b081e61 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Odini?= <raphodn@users.noreply.github.com>
Date: Mon, 9 Dec 2024 22:38:55 +0100
Subject: [PATCH] refactor(Price add): On barcode manual input, show result
 confirmation before send (#1108)

---
 src/components/BarcodeManualInputDialog.vue |  6 +-
 src/components/BarcodeScannerDialog.vue     | 68 +++++++++++++++------
 src/components/LocationSelectorDialog.vue   | 10 +--
 src/components/ProductInputRow.vue          |  2 +-
 4 files changed, 59 insertions(+), 27 deletions(-)

diff --git a/src/components/BarcodeManualInputDialog.vue b/src/components/BarcodeManualInputDialog.vue
index 72dcba75a59..df9225947f9 100644
--- a/src/components/BarcodeManualInputDialog.vue
+++ b/src/components/BarcodeManualInputDialog.vue
@@ -32,7 +32,7 @@
 <script>
 export default {
   props: {
-    preFillValue: {
+    barcodeInputPrefillValue: {
       type: String,
       default: ''
     }
@@ -51,8 +51,8 @@ export default {
     }
   },
   mounted() {
-    if (this.preFillValue) {
-      this.barcodeForm.barcode = this.preFillValue
+    if (this.barcodeInputPrefillValue) {
+      this.barcodeForm.barcode = this.barcodeInputPrefillValue
     }
     this.$refs.barcodeInput.focus()
   },
diff --git a/src/components/BarcodeScannerDialog.vue b/src/components/BarcodeScannerDialog.vue
index 22b69a5be48..44426c84f74 100644
--- a/src/components/BarcodeScannerDialog.vue
+++ b/src/components/BarcodeScannerDialog.vue
@@ -1,5 +1,5 @@
 <template>
-  <v-dialog scrollable max-height="80%" min-width="50%">
+  <v-dialog scrollable min-height="50%" max-height="80%" min-width="50%">
     <v-card>
       <v-card-title>
         {{ $t('Common.ProductFind') }} <v-btn style="float:right;" variant="text" density="compact" icon="mdi-close" @click="close" />
@@ -26,22 +26,23 @@
           </v-tabs-window-item>
 
           <v-tabs-window-item value="type">
-            <v-form @submit.prevent="onSubmit">
+            <v-form v-model="barcodeManualFormValid" class="mb-2" @submit.prevent="barcodeSearchOrSend">
               <v-text-field
-                ref="barcodeInput"
-                v-model="barcodeForm.barcode"
-                :label="$t('BarcodeManualInput.Barcode')"
+                ref="barcodeManualInput"
+                v-model="barcodeManualForm.barcode"
+                :label="$t('Common.Barcode')"
                 type="number"
                 inputmode="numeric"
                 prepend-inner-icon="mdi-barcode"
-                :hint="barcodeForm.barcode.length.toString()"
+                :hint="barcodeManualForm.barcode.length.toString()"
                 persistent-hint
               >
                 <template #append-inner>
-                  <v-icon icon="mdi-plus" :disabled="!formFilled" @click="onSubmit" />
+                  <v-icon :icon="barcodeManualInputMode === 'search' ? 'mdi-magnify' : 'mdi-plus'" :disabled="!barcodeManualFormValid" @click="barcodeSearchOrSend" />
                 </template>
               </v-text-field>
             </v-form>
+            <ProductCard v-if="product" :product="product" :hideCategoriesAndLabels="true" :hideProductActions="true" :readonly="true" elevation="1" @click="barcodeSend(product.code)" />
           </v-tabs-window-item>
         </v-tabs-window>
       </v-card-text>
@@ -63,6 +64,8 @@
 
 <script>
 import { Html5Qrcode, Html5QrcodeScanType } from 'html5-qrcode'
+import { defineAsyncComponent } from 'vue'
+import api from '../services/api'
 import constants from '../constants'
 
 const config = {
@@ -75,8 +78,15 @@ const config = {
 }
 
 export default {
+  components: {
+    ProductCard: defineAsyncComponent(() => import('../components/ProductCard.vue')),
+  },
   props: {
-    preFillValue: {
+    barcodeManualInputMode: {
+      type: String,
+      default: 'search'  // 'add'
+    },
+    barcodeManualInputPrefillValue: {
       type: String,
       default: ''
     }
@@ -85,9 +95,11 @@ export default {
   data() {
     return {
       scanner: null,
-      barcodeForm: {
+      barcodeManualForm: {
         barcode: '',
       },
+      barcodeManualFormValid: false,
+      product: null,
       // config
       displayItems: constants.PRODUCT_SELECTOR_DISPLAY_LIST,
       currentDisplay: constants.PRODUCT_SELECTOR_DISPLAY_LIST[0].key,  // scan
@@ -96,16 +108,18 @@ export default {
     }
   },
   computed: {
-    formFilled() {
-      return Object.values(this.barcodeForm).every(x => !!x)
-    }
+    barcodeManualInputRules() {
+      return [
+        (v) => !!v || '',
+      ]
+    },
   },
   mounted() {
     this.createQrcodeScanner()
     if (this.preFillValue) {
-      this.barcodeForm.barcode = this.preFillValue
+      this.barcodeManualForm.barcode = this.preFillValue
     }
-    // this.$refs.barcodeInput.focus()
+    // this.$refs.barcodeManualInput.focus()
   },
   methods: {
     createQrcodeScanner() {
@@ -113,14 +127,32 @@ export default {
       this.scanner.start({ facingMode: 'environment' }, config, this.onScanSuccess, this.onScanFailure)
     },
     onScanSuccess(decodedText, decodedResult) {  // eslint-disable-line no-unused-vars
-      this.$emit('barcode', decodedText)
-      this.close()
+      this.barcodeSend(decodedText)
     },
     onScanFailure(error) {  // eslint-disable-line no-unused-vars
       // console.warn(`Code scan error = ${error}`)
     },
-    onSubmit() {
-      this.$emit('barcode', this.barcodeForm.barcode)
+    barcodeSearchOrSend() {
+      if (!this.barcodeManualFormValid) return
+      if (this.barcodeManualInputMode === 'search') {
+        this.getProduct(this.barcodeManualForm.barcode)
+      } else {
+        this.barcodeSend(this.barcodeManualForm.barcode)
+      }
+    },
+    getProduct(code) {
+      this.product = null
+      api
+        .getProductByCode(code)
+        .then((data) => {
+          this.product = data.id ? data : {'code': code, 'price_count': 0}
+        })
+        .catch((error) => {  // eslint-disable-line no-unused-vars
+          alert("Error: Open Prices server error")
+        })
+    },
+    barcodeSend(barcode) {
+      this.$emit('barcode', barcode)
       this.close()
     },
     close() {
diff --git a/src/components/LocationSelectorDialog.vue b/src/components/LocationSelectorDialog.vue
index 279357b4bb2..38b47684828 100644
--- a/src/components/LocationSelectorDialog.vue
+++ b/src/components/LocationSelectorDialog.vue
@@ -36,19 +36,19 @@
           </v-tabs-window-item>
 
           <v-tabs-window-item value="osm">
-            <v-form v-model="locationOsmSearchFormValid" @submit.prevent="osmSearch">
+            <v-form v-model="locationOsmSearchFormValid" @submit.prevent="locationOsmSearch">
               <v-text-field
                 ref="locationOsmSearchInput"
                 v-model="locationOsmSearchForm.q"
                 :label="$t('Common.LocationSearchByName')"
                 :hint="$t('Common.ExamplesWithColonAndValue', { value: 'Carrefour rue la fayette 75010 paris ; Auchan Grenoble ; N12208020359' })"
                 type="text"
-                :rules="osmSearchRules"
+                :rules="locationOsmSearchInputRules"
                 :loading="loading"
                 persistent-hint
               >
                 <template #append-inner>
-                  <v-icon icon="mdi-magnify" :disabled="!locationOsmSearchFormValid" @click="osmSearch" />
+                  <v-icon icon="mdi-magnify" :disabled="!locationOsmSearchFormValid" @click="locationOsmSearch" />
                 </template>
               </v-text-field>
             </v-form>
@@ -181,7 +181,7 @@ export default {
     showLocationOSMID() {
       return this.appStore.user.username && this.appStore.user.location_display_osm_id
     },
-    osmSearchRules() {
+    locationOsmSearchInputRules() {
       return [
         (v) => !!v || '',
       ]
@@ -200,7 +200,7 @@ export default {
     fieldRequired(v) {
       return !!v
     },
-    osmSearch() {
+    locationOsmSearch() {
       if (!this.locationOsmSearchFormValid) return
       this.$refs.locationOsmSearchInput.blur()
       this.results = null
diff --git a/src/components/ProductInputRow.vue b/src/components/ProductInputRow.vue
index ba0f3ce4a7d..4a7791bf2b0 100644
--- a/src/components/ProductInputRow.vue
+++ b/src/components/ProductInputRow.vue
@@ -60,7 +60,7 @@
   <BarcodeScannerDialog
     v-if="barcodeScannerDialog"
     v-model="barcodeScannerDialog"
-    :preFillValue="productForm.product_code"
+    :barcodeInputPrefillValue="productForm.product_code"
     @barcode="setProductCode($event)"
     @close="barcodeScannerDialog = false"
   />