Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public Comment 1.8.3.2 Notation of property ReferenceSystem::dimension #77

Closed
chris-little opened this issue Feb 1, 2024 · 2 comments
Closed

Public Comment 1.8.3.2 Notation of property ReferenceSystem::dimension #77

chris-little opened this issue Feb 1, 2024 · 2 comments
Labels
Public Comment Issue from a formal Request for Public Comment

Comments

@chris-little
Copy link
Contributor

Section 7: In Figure 1, the notation of property ReferenceSystem::dimension is wrong. The property is singlevalued, not multivalued. Therefore, notation "dimension = 1..*" is wrong. A correct notation is "dimension {dimension >= 1}". Consider adding a data type (from ISO 19103) to specify the property further: "dimension: Integer {dimension >= 1}".
@chris-little chris-little added the Public Comment Issue from a formal Request for Public Comment label Feb 1, 2024
@chris-little
Copy link
Contributor Author

chris-little commented Feb 8, 2024 •
edited
Loading

Used "dimension {dimension >= 1}" to be as general as possible, but maybe fractal dimensions are a step too far! :-) Mermaid cannot handle braces or commas, so used dimension "dimension >= 1"

@chris-little
Copy link
Contributor Author

Addressed in PR #83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Public Comment Issue from a formal Request for Public Comment
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chris-little