Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation of requirement 10 #28

Closed
doublebyte1 opened this issue Jul 16, 2024 · 4 comments
Closed

Validation of requirement 10 #28

doublebyte1 opened this issue Jul 16, 2024 · 4 comments
Assignees
Milestone

Comments

@doublebyte1
Copy link

doublebyte1 commented Jul 16, 2024

Describe the bug
The ETS expects Dataset Tilesets, which according to the spec are not a core requirement. See the discussion here.

To Reproduce
Run the tests for a server that does not implement dataset tilesets:

https://maps.gnosis.earth/ogcapi/?f=json
https://demo.pygeoapi.io/master/?f=json

The ets produces an error.

Expected behavior
These servers do not claim to support dataset tilesets in the conformance declaration, and should not be tested for it. Instead they support collection tilesets.

Additional context
This issue is also related to the fact that a test that is not mandatory is being run.

@dstenger
Copy link
Contributor

Thank you for reporting.
Indeed, we already discussed this topic in the CITE team because a similar issue was reported in #13 as described above.

Our conclusion was that the test suite must be improved:

  • either the tests are skipped/removed/made optional
  • or further input parameters are added
  • or a precondition is defined for the ETS making an optional requirement mandatory for the test suite

We will do further discussion in the CITE team.

@dstenger dstenger added this to CITE Aug 1, 2024
@dstenger dstenger moved this to Needs discussion in CITE Aug 1, 2024
@dstenger dstenger moved this from In progress to To verify in CITE Aug 16, 2024
@dstenger dstenger assigned dstenger and unassigned bpross-52n Aug 16, 2024
@tomkralidis
Copy link

Looks like this has been addressed in #29, thanks! Is there a beta release anytime soon so we can test? Or a way to test locally (having Docker, not Maven)?

@dstenger
Copy link
Contributor

Yes, we will create a new Beta release at the end of this or next month.
Then, you can also download a Docker Image from DockerHub:

Right now, you can, of course, also test the fix. But then you have to build the test suite which requires Maven. If you need further instructions for that, please contact me.

@tomkralidis
Copy link

Thanks @dstenger. fwiw I was able to test locally using the local build instructions (ended up installing Maven).

dstenger added a commit that referenced this issue Aug 26, 2024
@dstenger dstenger added this to the 1.1 milestone Aug 26, 2024
@github-project-automation github-project-automation bot moved this from To verify to Done in CITE Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

5 participants