Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gui] Make sure parent dirs exist on Windows before creating the pg_service file #58

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[gui] Make sure parent dirs exist on Windows before creating the pg_service file #58

wants to merge 1 commit into from
+6 −0

Conversation

gacarrillor
Copy link
Contributor

Fix #57

3nids
3nids approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@3nids 3nids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good!

I'm just wondering if this would not be better placed in the lib though. That would be a nice functionnality.

@gacarrillor
Copy link
Contributor Author

gacarrillor commented Jan 6, 2025 •
edited
Loading

sounds good!

I'm just wondering if this would not be better placed in the lib though. That would be a nice functionnality.

I agree. Although there are several options for doing so. Just to name a couple:

  • A function create_file().
  • A boolean parameter in conf_path(). E.g., create or create_if_needed.

How do you think we should implement it there?

@3nids
Copy link
Member

3nids commented Jan 6, 2025

I'd vote for conf_path(create_if_missing=True)without strong opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3nids 3nids 3nids approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define a new pg config file on windows
2 participants
@gacarrillor @3nids