Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[actiontemplatehli] Remove add-on #15972

Merged
merged 1 commit into from
Dec 3, 2023
Merged

[actiontemplatehli] Remove add-on #15972

merged 1 commit into from
Dec 3, 2023

Conversation

GiviMAD
Copy link
Member

@GiviMAD GiviMAD commented Nov 28, 2023

Remove add-on, due to changes introduced in openhab/openhab-core#3853.

@GiviMAD
[actiontemplatehli] Remove add-on.
1066e02 
Signed-off-by: Miguel Álvarez <[email protected]>
@GiviMAD GiviMAD requested a review from a team as a code owner November 28, 2023 23:28
lolodomo
lolodomo approved these changes Dec 3, 2023
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit b86097c into openhab:main Dec 3, 2023
3 checks passed
@lolodomo lolodomo added this to the 4.1 milestone Dec 3, 2023
@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Dec 3, 2023
@lolodomo
Copy link
Contributor

lolodomo commented Dec 3, 2023

I added the tag "enhancement" just to have this PR mentioned in the 4.1 release notes.

I believe you now need to update the file update.lst in distro repo. I am not sure how for a binding removal.

@lolodomo lolodomo mentioned this pull request Dec 3, 2023
Open
@jlaur jlaur changed the title [actiontemplatehli] Remove add-on. [actiontemplatehli] Remove add-on Dec 3, 2023
@lolodomo
Copy link
Contributor

lolodomo commented Dec 3, 2023 •
edited
Loading

Also something similar to openhab/openhab-distro#1530

@GiviMAD
Copy link
Member Author

GiviMAD commented Dec 3, 2023

Thank you!

@lolodomo
Copy link
Contributor

@J-N-K @wborn : any advice what should be done exactly in openhab-distro when you remove a binding ?
Another binding was also removed: porcupineks => #16063

@J-N-K
Copy link
Member

J-N-K commented Dec 14, 2023

Something like openhab/openhab-distro#1530

austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@GiviMAD @austvik
[actiontemplatehli] Remove add-on. (openhab#15972)
9e050c6 
Signed-off-by: Miguel Álvarez <[email protected]>
Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@GiviMAD @lolodomo @J-N-K