-
-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binding ID in JarFileAddonService vs. KarafAddonService #4139
Comments
IMO add-on id and feature name should always be lower-case and never use camel-case. Is there any other example of that? |
I hope somebody else will comment and that's not a question for me, because that's exactly the clarification I'm looking for... If they should never be CamelCase I'd be interested if there is any chance to get the pjlink binding adapted without a breaking change. The issue is only noticable for those users who want to use the UI to add things, the binding is working fine for everybody else. |
We can rewrite the installed add-ons (see openhab/openhab-distro#1530), so only those that configure add-ons in addons.cfg will need to adjust it there. I don't think that there will be anything else to adjust for users. |
I think this has been answered. |
I have received a bug report in the PJLinkDevice binding, and I'm sure that the bug was not there in 2.5.x when the binding was introduced.
I suspect the way the core/ui handles binding IDs has changed. The interesting bit is that the functionality works perfectly fine when installed from a JAR, but it does not work when installed from the openhab distribution.
I have explained my observations here and raised some questions on how I should proceed with the bug.
Could one of @openhab/core-maintainers please comment?
The text was updated successfully, but these errors were encountered: