JSR223: Include automationManager in the Default preset

[dilyanpalauzov]

When writing rules in JSR 223, one ultimately has to access automationManager to do something useful. The presets - Default, RuleSimple, RuleSupport, RuleFactories, ScriptAction and cache - provide some implicit imports and objects (variables). The latter objects enable connecting the JSR223 code with the OH internals and installing some meaningful automation.

As the only way described at https://www.openhab.org/docs/configuration/jsr223.html to install a rule is to use automationManager and thus to import the RuleSupport preset, this preset has always to be included explicitly by the caller. The other items from the preset are not strictly necessary, as they can be obtained by imports. (And the imports are required to move as much code in Groovy as possible under the TypeChecked and CompileStatic annotations).

[jimtng]

You can obtain automationManager through scriptExtension.get("automationManager"). scriptExtension is injected by default, without having to import any presets.

[dilyanpalauzov]

Yes, this is indeed the case. But this is not documented at https://www.openhab.org/docs/configuration/jsr223.html, so scriptExtension.importPreset("RuleSupport") is always called in order to get access to automationManager.

[lolodomo]

You are welcome to improve the existing documentation.

[dilyanpalauzov]

You are welcome to improve the existing documentation.

When I try to improve the existing documentation, changes can get stuck: https://github.com/openhab/openhab-docs/pulls/dilyanpalauzov

[lolodomo]

Try to ping @florian-h05

[florian-h05]

I don't think automationManager belongs into the Default preset, as it is related to supporting rule creation.
The possibility to statically import other members of the RuleSupport preset should not change that relation.

I would suggest to improve the docs as @jimtng suggested and ping me, so I can take care the PR gets reviewed and merged.

[dilyanpalauzov]

I don't think automationManager belongs into the Default preset, as it is related to supporting rule creation.

Yes, if no rule creation is going to happen, why will somebody in first place use the JSR223 extension mechanism? JSR223 is used to create and activate rules.