Remove obsolete addons from managed configuration #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been reported that the removal of the javascript transformation in openHAB 4 results in warnings because the add-on could not be found during installation. Since the add-on is no longer present, it does not show up in the UI and can't be uninstalled from there. This adds an update instruction to remove it from the addons.config. Signed-off-by: Jan N. Klug <[email protected]>
wborn
reviewed
Jul 15, 2023
There was a problem hiding this comment.
Perhaps the other add-ons (#1481 (comment)) can also be removed similarly?
|
Yes. Do you see any better solution than these three lines? The problem is that we can only do simple "replace" instructions here and have the following cases:
|
The only better solution I can think of is adding dedicated update commands for removing or renaming add-ons. Then you can just use one command per add-on. Though adding new commands is quite involved because they need to work on Linux/macOS/Windows and added to all repos used for packaging openHAB (distro, linuxpkg, docker, etc). |
|
I'll add commands for the other addons |
Signed-off-by: Jan N. Klug <[email protected]>
J-N-K
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been reported that the removal of the javascript transformation in openHAB 4 results in warnings because the add-on could not be found during installation. Since the add-on is no longer present, it does not show up in the UI and can't be uninstalled from there. This adds an update instruction to remove it from the addons.config.