Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixing libraries within processing scripts #66

Open
shimwell opened this issue May 3, 2022 · 0 comments
Open

Mixing libraries within processing scripts #66

shimwell opened this issue May 3, 2022 · 0 comments

Comments

@shimwell
Copy link
Member

shimwell commented May 3, 2022

There is one case in this collection of scripts where individual files from another library are brought in to allow a more complete collection of nuclides to be processed.

The generate_jeff33.py makes use of TENDL cross sections for C13 and O17 and also adds some ENDF in for photons.

This has a few issues

  • It complicates the script which makes it hard to package up and remove duplicate code between scripts.

  • It potentially confuses the user who would reasonably believe they are getting exclusivity JEFF 33 cross sections (like all the other scripts).

There is another more transparent method available for users to obtain a more complete cross section collection with a JEFF 33 base. That to use the combine_libraries.py script that allows users to know what gets put into their library in a more predictable manner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant