Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currency field for Rate #120

Open
InrixParking opened this issue May 31, 2023 · 6 comments
Open

Currency field for Rate #120

InrixParking opened this issue May 31, 2023 · 6 comments
Milestone

Comments

@InrixParking
Copy link

Is your feature request related to a problem? Please describe.

We have data in non-USD countries

Describe the solution you'd like

An optional field for currency that takes ISO currency code

Is this a breaking change

  • No, not breaking

Impacted Spec

  • Curbs

Describe alternatives you've considered

Might be better in a higher-level object.

@schnuerle schnuerle added this to the 1.1 milestone Jun 27, 2023
@schnuerle
Copy link
Member

Discussion needed if people think this is urgent enough to including in the 1.0.1 patch release as a new rate_currency field, maybe at the Policy object level.

@mplsmitch
Copy link
Collaborator

The rate object is defined as

cents (or the smallest denomination of local currency)

So it seems this is possible but I agree using ISO 4217 would be much clearer.

@andrewdgh
Copy link

Using agreed-upon currency codes for the "local currency" seems to be the most straight forward

@schnuerle
Copy link
Member

The 'Rate' object seems like the right place, as this is where the rate in cents field is.

In MDS we specify a currency field e.g. in the cost of Trips, and description of the ISO 4217 code here.

Recommend adding an optional (empty means USD, like in MDS) currency field here to the Rate object. Actually seems like an oversight that we didn't do this at launch. May also want to add it to the Curb Event object?

@jiffyclub
Copy link

There is a currency field described at the top level of responses here: https://github.com/openmobilityfoundation/curb-data-specification/blob/1.0.0/general-information.md#rest-endpoints

Have not thought through how that intersects with every part of CDS to see whether that solves this use case or whether it's needed lower down as well.

@schnuerle
Copy link
Member

I think @jiffyclub is right, currency in meant to be returned with every single CDS endpoint.

Maybe what's needed here is better linking to this documentation so it can be more easily findable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants