-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currency field for Rate #120
Comments
Discussion needed if people think this is urgent enough to including in the 1.0.1 patch release as a new |
The
So it seems this is possible but I agree using ISO 4217 would be much clearer. |
Using agreed-upon currency codes for the "local currency" seems to be the most straight forward |
The 'Rate' object seems like the right place, as this is where the rate in cents field is. In MDS we specify a Recommend adding an optional (empty means USD, like in MDS) |
There is a currency field described at the top level of responses here: https://github.com/openmobilityfoundation/curb-data-specification/blob/1.0.0/general-information.md#rest-endpoints Have not thought through how that intersects with every part of CDS to see whether that solves this use case or whether it's needed lower down as well. |
I think @jiffyclub is right, Maybe what's needed here is better linking to this documentation so it can be more easily findable. |
Is your feature request related to a problem? Please describe.
We have data in non-USD countries
Describe the solution you'd like
An optional field for currency that takes ISO currency code
Is this a breaking change
Impacted Spec
Curbs
Describe alternatives you've considered
Might be better in a higher-level object.
The text was updated successfully, but these errors were encountered: