(feat) O3-4168: Add gender icons to the CarbonMRS icon pack #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniskigen
reviewed
Nov 14, 2024
There was a problem hiding this comment.
Thanks for working on this, @mccarthyaaron. I've left some suggestions.
packages/framework/esm-styleguide/src/icons/icon-registration.ts
Outdated
Show resolved
Hide resolved
packages/framework/esm-styleguide/src/icons/icon-registration.ts
Outdated
Show resolved
Hide resolved
denniskigen
reviewed
Nov 14, 2024
There was a problem hiding this comment.
Thanks for working on this, @mccarthyaaron. I've left some suggestions.
|
@denniskigen I have made some changes. Could you kindly take a look? |
denniskigen
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
feat,fix, orchore, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
This PR adds gender icons to the styleguide
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-4168
Other