-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(chore) Cache install dependencies step in e2e workflow #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 6.16 MB ℹ️ View Unchanged
|
ibacher
approved these changes
Dec 11, 2024
Makes it so that the `Install dependencies` step in the `run-e2e-on-other-repos` job is cached. Without caching, this step takes a full 2 minutes to run for Patient Chart. The commit also adds working-directory directives to keep the cache keys specific to the active repo. Additionally, these changes makes artifact names and steps more explicit by adding the repo name to both the artifact name and step name.
denniskigen
force-pushed
the
chore/e2e-caching
branch
from
December 13, 2024 18:51
9fbbe86
to
9faf4e6
Compare
ibacher
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
feat
,fix
, orchore
, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
Makes it so that the
Install dependencies
step in therun-e2e-on-other-repos
job is cached. Without caching, this step takes a full 2 minutes to run for Patient Chart. The commit also adds working-directory directives to keep the cache keys specific to the active repo. Additionally, these changes makes artifact names and steps more explicit by adding the repo name to both the artifact name and step name.Screenshots
Related Issue
Other