(feat) Support for automatically overriding routes and Carbonize devtools #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -717 kB (-21%) 🎉 Total Size: 2.71 MB
ℹ️ View Unchanged
|
denniskigen
reviewed
Nov 17, 2023
denniskigen
reviewed
Nov 17, 2023
denniskigen
reviewed
Nov 17, 2023
4 tasks
|
@ibacher, it looks like when I add a module override, and then subsequently remove it, the add-and-remove-override.mp4 |
|
@denniskigen I see... So, clicking on the "Reset all overrides" was, stupidly, not something I added something for (it should do the right thing if you individually disable the override). |
|
Hopefully that's fixed now! |
denniskigen
approved these changes
Dec 4, 2023
packages/apps/esm-devtools-app/src/devtools/import-map-list/list.component.tsx
Outdated
Show resolved
Hide resolved
packages/apps/esm-devtools-app/src/devtools/import-map-list/list.component.tsx
Show resolved
Hide resolved
packages/apps/esm-devtools-app/src/devtools/import-map-list/list.component.tsx
Show resolved
Hide resolved
packages/apps/esm-devtools-app/src/devtools/import-map-list/modal.component.tsx
Show resolved
Hide resolved
|
One nice thing to support that the library supports is the ability to specify a port number and have the tooling fill out the override URL for you automatically: port-number-in-overrides-panel.mp4 |
denniskigen
force-pushed
the
feat/routes-in-devtools
branch
from
17f9378 to
5371a14
Compare
Yeah, I've found that to be kinda flaky personally, but it's pretty easy to implement. I'll add it in. |
denniskigen
force-pushed
the
feat/routes-in-devtools
branch
from
9750fb4 to
ab39f24
Compare
In that case, probably best to leave it out. |
denniskigen
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
For changes to apps
If applicable
Summary
This is the first in a planned series of commits to build out better dev tooling for handling stuff related to routes.json files, used by Core V5. The goal of this PR is pretty straight-forward: when adding an app to the import-map-overrides, we should load the routes, if any along-side that.
This does several things:
openmrs-routes:<name of module>, e.g.,openmrs-routes:@openmrs/esm-patient-chart-app. The value for this can be either a JSON string (so double-quotes) that points to a URL that resolves to a customroutes.json(this is how 3 above is implemented) or a stringified JSON object that conforms to the routes schema. There is currently no UI for this other than your browser devtools.Screenshots
Related Issue
Other
Future plans:
developand some other commands. I thought that I wrote the code to also support that for routes, but it doesn't work, so I'm going to fix that up.