-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) Fix regression in implementer tools affecting MultiSelect components #844
Conversation
Size Change: -60.4 kB (-2%) Total Size: 2.62 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @donaldkibet! Code looks great. Before merging this in, though, could we retitle the PR? I don’t think anyone looking at a commit with that name would have any idea what this does.
Maybe something like “Fix a regression in implementer tools ability to add or remove extensions”
@ibacher, I've updated the PR title and description. Thanks for the fix, @donaldkibet. |
Requirements
feat
,fix
, orchore
, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
This PR fixes a regression in the implementer tools panel affecting Carbon MultiSelect components. It replaces the existing dropdown implementation with the Filterable variant of the
MultiSelect
component. See the linked GIF for a visual of the fix in practice.Screenshots
regression-affecting-dropdowns-in-implementer-tools.mp4
Related Issue
None
Other
None