Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix config mocks #862

Merged
merged 1 commit into from
Dec 24, 2023
Merged

fix: Fix config mocks #862

merged 1 commit into from
Dec 24, 2023

Conversation

brandones
Copy link
Collaborator

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. Ensure your PR title includes a conventional commit label (such as feat, fix, or chore, among others). See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

These mocks weren't working because the return value of the mock was getting set at initialization time, which was before defineConfigSchema would get called. This should make it possible to replace a lot of config-mocking code with calls to defineConfigSchema.

Copy link
Contributor

Size Change: 0 B

Total Size: 2.72 MB

ℹ️ View Unchanged
Filename Size
packages/apps/esm-devtools-app/dist/630.js 1.76 kB
packages/apps/esm-devtools-app/dist/729.js 6.79 kB
packages/apps/esm-devtools-app/dist/735.js 2.63 kB
packages/apps/esm-devtools-app/dist/788.js 42.9 kB
packages/apps/esm-devtools-app/dist/875.js 9.76 kB
packages/apps/esm-devtools-app/dist/889.js 109 kB
packages/apps/esm-devtools-app/dist/961.js 25.3 kB
packages/apps/esm-devtools-app/dist/988.js 328 B
packages/apps/esm-devtools-app/dist/main.js 3.14 kB
packages/apps/esm-devtools-app/dist/openmrs-esm-devtools-app.js 3.18 kB
packages/apps/esm-implementer-tools-app/dist/319.js 633 B
packages/apps/esm-implementer-tools-app/dist/329.js 10 kB
packages/apps/esm-implementer-tools-app/dist/426.js 1.66 kB
packages/apps/esm-implementer-tools-app/dist/460.js 735 B
packages/apps/esm-implementer-tools-app/dist/56.js 3.07 kB
packages/apps/esm-implementer-tools-app/dist/560.js 9.6 kB
packages/apps/esm-implementer-tools-app/dist/574.js 560 B
packages/apps/esm-implementer-tools-app/dist/587.js 2.81 kB
packages/apps/esm-implementer-tools-app/dist/620.js 126 kB
packages/apps/esm-implementer-tools-app/dist/625.js 562 B
packages/apps/esm-implementer-tools-app/dist/651.js 6.86 kB
packages/apps/esm-implementer-tools-app/dist/727.js 32.9 kB
packages/apps/esm-implementer-tools-app/dist/735.js 2.63 kB
packages/apps/esm-implementer-tools-app/dist/738.js 6.79 kB
packages/apps/esm-implementer-tools-app/dist/757.js 560 B
packages/apps/esm-implementer-tools-app/dist/788.js 42.9 kB
packages/apps/esm-implementer-tools-app/dist/807.js 559 B
packages/apps/esm-implementer-tools-app/dist/833.js 681 B
packages/apps/esm-implementer-tools-app/dist/889.js 109 kB
packages/apps/esm-implementer-tools-app/dist/913.js 61.2 kB
packages/apps/esm-implementer-tools-app/dist/main.js 73.3 kB
packages/apps/esm-implementer-tools-app/dist/openmrs-esm-implementer-tools-app.js 3.3 kB
packages/apps/esm-login-app/dist/111.js 1.22 kB
packages/apps/esm-login-app/dist/126.js 2.5 kB
packages/apps/esm-login-app/dist/173.js 1.22 kB
packages/apps/esm-login-app/dist/224.js 256 B
packages/apps/esm-login-app/dist/236.js 272 B
packages/apps/esm-login-app/dist/240.js 364 B
packages/apps/esm-login-app/dist/272.js 264 B
packages/apps/esm-login-app/dist/319.js 692 B
packages/apps/esm-login-app/dist/336.js 234 B
packages/apps/esm-login-app/dist/370.js 30.6 kB
packages/apps/esm-login-app/dist/460.js 782 B
packages/apps/esm-login-app/dist/539.js 298 B
packages/apps/esm-login-app/dist/56.js 3.06 kB
packages/apps/esm-login-app/dist/574.js 609 B
packages/apps/esm-login-app/dist/625.js 600 B
packages/apps/esm-login-app/dist/627.js 257 B
packages/apps/esm-login-app/dist/63.js 16.5 kB
packages/apps/esm-login-app/dist/644.js 305 B
packages/apps/esm-login-app/dist/673.js 284 B
packages/apps/esm-login-app/dist/729.js 6.78 kB
packages/apps/esm-login-app/dist/735.js 2.63 kB
packages/apps/esm-login-app/dist/757.js 698 B
packages/apps/esm-login-app/dist/788.js 42.9 kB
packages/apps/esm-login-app/dist/807.js 961 B
packages/apps/esm-login-app/dist/812.js 22.5 kB
packages/apps/esm-login-app/dist/833.js 727 B
packages/apps/esm-login-app/dist/889.js 109 kB
packages/apps/esm-login-app/dist/main.js 57 kB
packages/apps/esm-login-app/dist/openmrs-esm-login-app.js 3.32 kB
packages/apps/esm-offline-tools-app/dist/102.js 81.3 kB
packages/apps/esm-offline-tools-app/dist/193.js 55 kB
packages/apps/esm-offline-tools-app/dist/319.js 1.14 kB
packages/apps/esm-offline-tools-app/dist/460.js 1.32 kB
packages/apps/esm-offline-tools-app/dist/56.js 3.07 kB
packages/apps/esm-offline-tools-app/dist/574.js 1.04 kB
packages/apps/esm-offline-tools-app/dist/625.js 1.04 kB
packages/apps/esm-offline-tools-app/dist/63.js 16.5 kB
packages/apps/esm-offline-tools-app/dist/729.js 6.79 kB
packages/apps/esm-offline-tools-app/dist/735.js 2.63 kB
packages/apps/esm-offline-tools-app/dist/757.js 1.2 kB
packages/apps/esm-offline-tools-app/dist/788.js 42.9 kB
packages/apps/esm-offline-tools-app/dist/807.js 1.1 kB
packages/apps/esm-offline-tools-app/dist/833.js 1.22 kB
packages/apps/esm-offline-tools-app/dist/889.js 109 kB
packages/apps/esm-offline-tools-app/dist/main.js 136 kB
packages/apps/esm-offline-tools-app/dist/openmrs-esm-offline-tools-app.js 3.29 kB
packages/apps/esm-primary-navigation-app/dist/262.js 13.3 kB
packages/apps/esm-primary-navigation-app/dist/319.js 200 B
packages/apps/esm-primary-navigation-app/dist/460.js 217 B
packages/apps/esm-primary-navigation-app/dist/574.js 183 B
packages/apps/esm-primary-navigation-app/dist/625.js 184 B
packages/apps/esm-primary-navigation-app/dist/63.js 16.5 kB
packages/apps/esm-primary-navigation-app/dist/729.js 6.79 kB
packages/apps/esm-primary-navigation-app/dist/735.js 18.7 kB
packages/apps/esm-primary-navigation-app/dist/757.js 209 B
packages/apps/esm-primary-navigation-app/dist/788.js 42.9 kB
packages/apps/esm-primary-navigation-app/dist/807.js 235 B
packages/apps/esm-primary-navigation-app/dist/833.js 210 B
packages/apps/esm-primary-navigation-app/dist/889.js 109 kB
packages/apps/esm-primary-navigation-app/dist/960.js 2.64 kB
packages/apps/esm-primary-navigation-app/dist/main.js 33.7 kB
packages/apps/esm-primary-navigation-app/dist/openmrs-esm-primary-navigation-app.js 3.23 kB
packages/framework/esm-api/dist/openmrs-esm-api.js 10 kB
packages/framework/esm-breadcrumbs/dist/openmrs-esm-breadcrumbs.js 2.66 kB
packages/framework/esm-config/dist/openmrs-esm-module-config.js 7.87 kB
packages/framework/esm-dynamic-loading/dist/openmrs-esm-dynamic-loading.js 2.12 kB
packages/framework/esm-error-handling/dist/openmrs-esm-error-handling.js 894 B
packages/framework/esm-extensions/dist/openmrs-esm-extensions.js 8.05 kB
packages/framework/esm-feature-flags/dist/openmrs-esm-feature-flags.js 1.67 kB
packages/framework/esm-framework/dist/455.openmrs-esm-framework.js 4.57 kB
packages/framework/esm-framework/dist/530.openmrs-esm-framework.js 2.92 kB
packages/framework/esm-framework/dist/645.openmrs-esm-framework.js 9.31 kB
packages/framework/esm-framework/dist/655.openmrs-esm-framework.js 6.83 kB
packages/framework/esm-framework/dist/710.openmrs-esm-framework.js 6.48 kB
packages/framework/esm-framework/dist/735.openmrs-esm-framework.js 2.66 kB
packages/framework/esm-framework/dist/788.openmrs-esm-framework.js 42.9 kB
packages/framework/esm-framework/dist/openmrs-esm-framework.js 376 kB
packages/framework/esm-globals/dist/openmrs-esm-globals.js 756 B
packages/framework/esm-offline/dist/openmrs-esm-offline.js 34.4 kB
packages/framework/esm-react-utils/dist/openmrs-esm-react-utils.js 15.4 kB
packages/framework/esm-routes/dist/openmrs-esm-utils.js 1.46 kB
packages/framework/esm-state/dist/openmrs-esm-state.js 888 B
packages/framework/esm-styleguide/dist/openmrs-esm-styleguide.js 19.3 kB
packages/framework/esm-utils/dist/openmrs-esm-utils.js 11 kB
packages/shell/esm-app-shell/dist/695f23c4e6b3f009.js 1.58 kB
packages/shell/esm-app-shell/dist/ac8d5a139c1f4027.js 6.45 kB
packages/shell/esm-app-shell/dist/b66a463116735f62.js 3.81 kB
packages/shell/esm-app-shell/dist/openmrs.0342febe2d71d72c.js 334 kB
packages/shell/esm-app-shell/dist/service-worker.js 60.5 kB
packages/tooling/openmrs/dist/cli.js 2.86 kB
packages/tooling/openmrs/dist/commands/assemble.js 2.4 kB
packages/tooling/openmrs/dist/commands/build.js 1.34 kB
packages/tooling/openmrs/dist/commands/debug.js 545 B
packages/tooling/openmrs/dist/commands/develop.js 1.86 kB
packages/tooling/openmrs/dist/commands/index.js 438 B
packages/tooling/openmrs/dist/commands/start.js 851 B
packages/tooling/openmrs/dist/index.js 517 B
packages/tooling/openmrs/dist/runner.js 637 B
packages/tooling/openmrs/dist/utils/config.js 728 B
packages/tooling/openmrs/dist/utils/debugger.js 528 B
packages/tooling/openmrs/dist/utils/dependencies.js 640 B
packages/tooling/openmrs/dist/utils/helpers.js 395 B
packages/tooling/openmrs/dist/utils/importmap.js 3.02 kB
packages/tooling/openmrs/dist/utils/index.js 444 B
packages/tooling/openmrs/dist/utils/logger.js 368 B
packages/tooling/openmrs/dist/utils/npmConfig.js 830 B
packages/tooling/openmrs/dist/utils/untar.js 722 B
packages/tooling/openmrs/dist/utils/variables.js 192 B
packages/tooling/openmrs/dist/utils/webpack.js 278 B
packages/tooling/webpack-config/dist/index.js 3.58 kB

compressed-size-action

Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @brandones!

@denniskigen denniskigen merged commit c16d093 into main Dec 24, 2023
8 of 9 checks passed
@denniskigen denniskigen deleted the config-mocks branch December 24, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants