From 0b3e877e36a20f30da673c2625a858863f227949 Mon Sep 17 00:00:00 2001
From: chibongho <cbho@pih.org>
Date: Thu, 12 Dec 2024 16:56:23 -0500
Subject: [PATCH] =?UTF-8?q?(fix)=20O3-4271=20Service=20Queues=20-=20fix=20?=
 =?UTF-8?q?form=20to=20start=20service=20queues=20for=20p=E2=80=A6=20(#141?=
 =?UTF-8?q?1)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* (fix) O3-4271 Service Queues - fix form to start service queues for patient with existing visit

* minor fixup
---
 .../patient-appointments-base.test.tsx        |  2 +-
 ...t-upcoming-appointments-card.component.tsx | 68 +++++++++++--------
 .../existing-visit-form.component.tsx         | 12 ++--
 .../queue-fields/queue-fields.component.tsx   | 59 +++++++---------
 .../queue-fields/queue-fields.scss            |  4 --
 .../queue-fields/queue-fields.test.tsx        |  5 +-
 .../visit-form-queue-fields.extension.tsx     |  9 ++-
 .../translations/en.json                      |  1 -
 8 files changed, 84 insertions(+), 76 deletions(-)

diff --git a/packages/esm-appointments-app/src/patient-appointments/patient-appointments-base.test.tsx b/packages/esm-appointments-app/src/patient-appointments/patient-appointments-base.test.tsx
index 2ef78d564..7e509c33b 100644
--- a/packages/esm-appointments-app/src/patient-appointments/patient-appointments-base.test.tsx
+++ b/packages/esm-appointments-app/src/patient-appointments/patient-appointments-base.test.tsx
@@ -14,7 +14,7 @@ const testProps = {
 
 const mockOpenmrsFetch = jest.mocked(openmrsFetch);
 
-describe('AppointmensOverview', () => {
+describe('AppointmentsOverview', () => {
   it('renders an empty state if appointments data is unavailable', async () => {
     mockOpenmrsFetch.mockResolvedValueOnce({
       data: [],
diff --git a/packages/esm-appointments-app/src/patient-appointments/patient-upcoming-appointments-card.component.tsx b/packages/esm-appointments-app/src/patient-appointments/patient-upcoming-appointments-card.component.tsx
index cee3684ad..ace547b74 100644
--- a/packages/esm-appointments-app/src/patient-appointments/patient-upcoming-appointments-card.component.tsx
+++ b/packages/esm-appointments-app/src/patient-appointments/patient-upcoming-appointments-card.component.tsx
@@ -1,4 +1,4 @@
-import React, { useEffect, useMemo, useState } from 'react';
+import React, { useCallback, useEffect, useMemo, useState } from 'react';
 import { useTranslation } from 'react-i18next';
 import {
   InlineLoading,
@@ -18,9 +18,13 @@ import dayjs from 'dayjs';
 import { type Appointment } from '../types';
 import { useMutateAppointments } from '../form/appointments-form.resource';
 
+interface VisitFormCallbacks {
+  onVisitCreatedOrUpdated: (visit: Visit) => Promise<any>;
+}
+
 // See VisitFormExtensionState in esm-patient-chart-app
 export interface PatientUpcomingAppointmentsProps {
-  setOnVisitCreatedOrUpdated(onSubmit: (visit: Visit) => Promise<any>);
+  setVisitFormCallbacks(callbacks: VisitFormCallbacks);
   visitFormOpenedFrom: string;
   patientChartConfig?: {
     showUpcomingAppointments: boolean;
@@ -36,7 +40,7 @@ export interface PatientUpcomingAppointmentsProps {
  */
 const PatientUpcomingAppointmentsCard: React.FC<PatientUpcomingAppointmentsProps> = ({
   patientUuid,
-  setOnVisitCreatedOrUpdated,
+  setVisitFormCallbacks,
   patientChartConfig,
 }) => {
   const { t } = useTranslation();
@@ -44,37 +48,45 @@ const PatientUpcomingAppointmentsCard: React.FC<PatientUpcomingAppointmentsProps
   const headerTitle = t('upcomingAppointments', 'Upcoming appointments');
   const [selectedAppointment, setSelectedAppointment] = useState<Appointment>(null);
   const { mutateAppointments } = useMutateAppointments();
+  const memoMutateAppointments = useMemo(() => mutateAppointments, [mutateAppointments]);
 
   const ac = useMemo<AbortController>(() => new AbortController(), []);
   useEffect(() => () => ac.abort(), [ac]);
   const { data: appointmentsData, error, isLoading } = usePatientAppointments(patientUuid, startDate, ac);
 
-  useEffect(() => {
-    setOnVisitCreatedOrUpdated(() => {
-      if (selectedAppointment) {
-        return changeAppointmentStatus('CheckedIn', selectedAppointment.uuid)
-          .then(() => {
-            mutateAppointments();
-            showSnackbar({
-              isLowContrast: true,
-              kind: 'success',
-              subtitle: t('appointmentMarkedChecked', 'Appointment marked as Checked In'),
-              title: t('appointmentCheckedIn', 'Appointment Checked In'),
-            });
-          })
-          .catch((error) => {
-            showSnackbar({
-              title: t('updateError', 'Error updating upcoming appointment'),
-              kind: 'error',
-              isLowContrast: false,
-              subtitle: error?.message,
+  const onVisitCreatedOrUpdated = useMemo(
+    () => ({
+      onVisitCreatedOrUpdated: () => {
+        if (selectedAppointment) {
+          return changeAppointmentStatus('CheckedIn', selectedAppointment.uuid)
+            .then(() => {
+              memoMutateAppointments();
+              showSnackbar({
+                isLowContrast: true,
+                kind: 'success',
+                subtitle: t('appointmentMarkedChecked', 'Appointment marked as Checked In'),
+                title: t('appointmentCheckedIn', 'Appointment Checked In'),
+              });
+            })
+            .catch((error) => {
+              showSnackbar({
+                title: t('updateError', 'Error updating upcoming appointment'),
+                kind: 'error',
+                isLowContrast: false,
+                subtitle: error?.message,
+              });
             });
-          });
-      } else {
-        return Promise.resolve();
-      }
-    });
-  }, [selectedAppointment, mutateAppointments, setOnVisitCreatedOrUpdated, t]);
+        } else {
+          return Promise.resolve();
+        }
+      },
+    }),
+    [selectedAppointment, memoMutateAppointments, t],
+  );
+
+  useEffect(() => {
+    setVisitFormCallbacks(onVisitCreatedOrUpdated);
+  }, [onVisitCreatedOrUpdated, setVisitFormCallbacks]);
 
   const todaysAppointments = appointmentsData?.todaysAppointments?.length ? appointmentsData?.todaysAppointments : [];
   const futureAppointments = appointmentsData?.upcomingAppointments?.length
diff --git a/packages/esm-service-queues-app/src/create-queue-entry/existing-visit-form/existing-visit-form.component.tsx b/packages/esm-service-queues-app/src/create-queue-entry/existing-visit-form/existing-visit-form.component.tsx
index 2c08264b0..ec0a27e2b 100644
--- a/packages/esm-service-queues-app/src/create-queue-entry/existing-visit-form/existing-visit-form.component.tsx
+++ b/packages/esm-service-queues-app/src/create-queue-entry/existing-visit-form/existing-visit-form.component.tsx
@@ -22,22 +22,26 @@ const ExistingVisitForm: React.FC<ExistingVisitFormProps> = ({ visit, closeWorks
   const [isSubmitting, setIsSubmitting] = useState(false);
 
   const { mutateQueueEntries } = useMutateQueueEntries();
-  const [submitQueueEntry, setSubmitQueueEntry] = useState<(visit: Visit, patientUuid: string) => Promise<any>>(null);
+  const [callback, setCallback] = useState<{
+    submitQueueEntry: (visit: Visit) => Promise<any>;
+  }>(null);
 
   const handleSubmit = useCallback(
     (event) => {
       event.preventDefault();
       setIsSubmitting(true);
 
-      submitQueueEntry?.(visit, visit.patient.uuid)
+      callback
+        ?.submitQueueEntry?.(visit)
         ?.then(() => {
           closeWorkspace();
+          mutateQueueEntries();
         })
         ?.finally(() => {
           setIsSubmitting(false);
         });
     },
-    [closeWorkspace, submitQueueEntry, visit],
+    [closeWorkspace, callback, visit, mutateQueueEntries],
   );
 
   return visit ? (
@@ -52,7 +56,7 @@ const ExistingVisitForm: React.FC<ExistingVisitFormProps> = ({ visit, closeWorks
         </Row>
       )}
       <Form className={classNames(styles.form, styles.container)} onSubmit={handleSubmit}>
-        <QueueFields setOnSubmit={setSubmitQueueEntry} />
+        <QueueFields setOnSubmit={(onSubmit) => setCallback({ submitQueueEntry: onSubmit })} />
         <ButtonSet className={isTablet ? styles.tablet : styles.desktop}>
           <Button className={styles.button} kind="secondary" onClick={closeWorkspace}>
             {t('discard', 'Discard')}
diff --git a/packages/esm-service-queues-app/src/create-queue-entry/queue-fields/queue-fields.component.tsx b/packages/esm-service-queues-app/src/create-queue-entry/queue-fields/queue-fields.component.tsx
index fb4ca0922..9ad6d2c79 100644
--- a/packages/esm-service-queues-app/src/create-queue-entry/queue-fields/queue-fields.component.tsx
+++ b/packages/esm-service-queues-app/src/create-queue-entry/queue-fields/queue-fields.component.tsx
@@ -1,6 +1,3 @@
-import React, { useContext, useEffect, useState } from 'react';
-import { useTranslation } from 'react-i18next';
-import classNames from 'classnames';
 import {
   InlineNotification,
   RadioButton,
@@ -9,16 +6,17 @@ import {
   Select,
   SelectItem,
   SelectSkeleton,
-  TextInput,
 } from '@carbon/react';
-import { useConfig, ResponsiveWrapper, useSession, type Visit, showSnackbar } from '@openmrs/esm-framework';
+import { ResponsiveWrapper, showSnackbar, useConfig, useSession, type Visit } from '@openmrs/esm-framework';
+import React, { useCallback, useContext, useEffect, useState } from 'react';
+import { useTranslation } from 'react-i18next';
 import { type ConfigObject } from '../../config-schema';
+import { useMutateQueueEntries } from '../../hooks/useQueueEntries';
 import { useQueues } from '../../hooks/useQueues';
-import { useQueueLocations } from '../hooks/useQueueLocations';
 import { AddPatientToQueueContext } from '../create-queue-entry.workspace';
-import styles from './queue-fields.scss';
-import { useMutateQueueEntries } from '../../hooks/useQueueEntries';
+import { useQueueLocations } from '../hooks/useQueueLocations';
 import { postQueueEntry } from './queue-fields.resource';
+import styles from './queue-fields.scss';
 
 export interface QueueFieldsProps {
   setOnSubmit(onSubmit: (visit: Visit) => Promise<any>);
@@ -42,11 +40,12 @@ const QueueFields: React.FC<QueueFieldsProps> = ({ setOnSubmit }) => {
   const [priority, setPriority] = useState(defaultPriorityConceptUuid);
   const priorities = queues.find((q) => q.uuid === selectedService)?.allowedPriorities ?? [];
   const { mutateQueueEntries } = useMutateQueueEntries();
+  const memoMutateQueueEntries = useCallback(mutateQueueEntries, [mutateQueueEntries]);
 
   const sortWeight = priority === emergencyPriorityConceptUuid ? 1 : 0;
 
-  useEffect(() => {
-    setOnSubmit?.((visit: Visit) => {
+  const onSubmit = useCallback(
+    (visit: Visit) => {
       if (selectedQueueLocation && selectedService && priority) {
         return postQueueEntry(
           visit.uuid,
@@ -65,7 +64,7 @@ const QueueFields: React.FC<QueueFieldsProps> = ({ setOnSubmit }) => {
               title: t('addedPatientToQueue', 'Added patient to queue'),
               subtitle: t('queueEntryAddedSuccessfully', 'Queue entry added successfully'),
             });
-            mutateQueueEntries();
+            memoMutateQueueEntries();
           })
           .catch((error) => {
             showSnackbar({
@@ -79,18 +78,22 @@ const QueueFields: React.FC<QueueFieldsProps> = ({ setOnSubmit }) => {
       } else {
         return Promise.resolve();
       }
-    });
-  }, [
-    selectedQueueLocation,
-    selectedService,
-    priority,
-    sortWeight,
-    defaultStatusConceptUuid,
-    visitQueueNumberAttributeUuid,
-    mutateQueueEntries,
-    setOnSubmit,
-    t,
-  ]);
+    },
+    [
+      selectedQueueLocation,
+      selectedService,
+      priority,
+      sortWeight,
+      defaultStatusConceptUuid,
+      visitQueueNumberAttributeUuid,
+      memoMutateQueueEntries,
+      t,
+    ],
+  );
+
+  useEffect(() => {
+    setOnSubmit?.(onSubmit);
+  }, [onSubmit, setOnSubmit]);
 
   useEffect(() => {
     if (currentServiceQueueUuid) {
@@ -201,16 +204,6 @@ const QueueFields: React.FC<QueueFieldsProps> = ({ setOnSubmit }) => {
           ) : null}
         </section>
       ) : null}
-
-      <section className={classNames(styles.section, styles.sectionHidden)}>
-        <TextInput
-          type="number"
-          id="sortWeight"
-          name="sortWeight"
-          labelText={t('sortWeight', 'Sort weight')}
-          value={sortWeight}
-        />
-      </section>
     </div>
   );
 };
diff --git a/packages/esm-service-queues-app/src/create-queue-entry/queue-fields/queue-fields.scss b/packages/esm-service-queues-app/src/create-queue-entry/queue-fields/queue-fields.scss
index 9a0e81ee5..d4768a431 100644
--- a/packages/esm-service-queues-app/src/create-queue-entry/queue-fields/queue-fields.scss
+++ b/packages/esm-service-queues-app/src/create-queue-entry/queue-fields/queue-fields.scss
@@ -11,7 +11,3 @@
 .section {
   margin: layout.$spacing-07 layout.$spacing-05 0;
 }
-
-.sectionHidden {
-  display: none;
-}
diff --git a/packages/esm-service-queues-app/src/create-queue-entry/queue-fields/queue-fields.test.tsx b/packages/esm-service-queues-app/src/create-queue-entry/queue-fields/queue-fields.test.tsx
index 9e6557439..4b3815164 100644
--- a/packages/esm-service-queues-app/src/create-queue-entry/queue-fields/queue-fields.test.tsx
+++ b/packages/esm-service-queues-app/src/create-queue-entry/queue-fields/queue-fields.test.tsx
@@ -59,12 +59,13 @@ describe('QueueFields', () => {
   it('renders the form fields and returns the set values', async () => {
     const user = userEvent.setup();
     let onSubmit: (visit: Visit) => Promise<any> = null;
-    const setOnSubmit = (callback) => (onSubmit = callback);
+    const setOnSubmit = (callback) => {
+      onSubmit = callback;
+    };
     render(<QueueFields setOnSubmit={setOnSubmit} />);
 
     expect(screen.getByLabelText('Select a queue location')).toBeInTheDocument();
     expect(screen.getByLabelText('Select a service')).toBeInTheDocument();
-    expect(screen.getByLabelText('Sort weight')).toBeInTheDocument();
 
     const queueUuid = 'e2ec9cf0-ec38-4d2b-af6c-59c82fa30b90';
     const serviceSelect = screen.getByLabelText('Select a service').closest('select');
diff --git a/packages/esm-service-queues-app/src/create-queue-entry/queue-fields/visit-form-queue-fields.extension.tsx b/packages/esm-service-queues-app/src/create-queue-entry/queue-fields/visit-form-queue-fields.extension.tsx
index 49433f40b..523661026 100644
--- a/packages/esm-service-queues-app/src/create-queue-entry/queue-fields/visit-form-queue-fields.extension.tsx
+++ b/packages/esm-service-queues-app/src/create-queue-entry/queue-fields/visit-form-queue-fields.extension.tsx
@@ -2,9 +2,12 @@ import { type Visit } from '@openmrs/esm-framework';
 import React from 'react';
 import QueueFields from './queue-fields.component';
 
+interface VisitFormCallbacks {
+  onVisitCreatedOrUpdated: (visit: Visit) => Promise<any>;
+}
 // See VisitFormExtensionState in esm-patient-chart-app
 export interface VisitFormQueueFieldsProps {
-  setOnVisitCreatedOrUpdated(onSubmit: (visit: Visit) => Promise<any>);
+  setVisitFormCallbacks: (callbacks: VisitFormCallbacks) => void;
   visitFormOpenedFrom: string;
   patientChartConfig?: {
     showServiceQueueFields: boolean;
@@ -17,9 +20,9 @@ export interface VisitFormQueueFieldsProps {
  * It is used slotted into the patient-chart's start visit form
  */
 const VisitFormQueueFields: React.FC<VisitFormQueueFieldsProps> = (props) => {
-  const { setOnVisitCreatedOrUpdated, visitFormOpenedFrom, patientChartConfig } = props;
+  const { setVisitFormCallbacks, visitFormOpenedFrom, patientChartConfig } = props;
   if (patientChartConfig.showServiceQueueFields || visitFormOpenedFrom == 'service-queues-add-patient') {
-    return <QueueFields setOnSubmit={setOnVisitCreatedOrUpdated} />;
+    return <QueueFields setOnSubmit={(onSubmit) => setVisitFormCallbacks({ onVisitCreatedOrUpdated: onSubmit })} />;
   } else {
     return <></>;
   }
diff --git a/packages/esm-service-queues-app/translations/en.json b/packages/esm-service-queues-app/translations/en.json
index 918d1b4ea..1ac2df614 100644
--- a/packages/esm-service-queues-app/translations/en.json
+++ b/packages/esm-service-queues-app/translations/en.json
@@ -196,7 +196,6 @@
   "serviceIsRequired": "Service is required",
   "serviceQueue": "Service queue",
   "serviceQueues": "Service queues",
-  "sortWeight": "Sort weight",
   "sp02": "Sp02",
   "startAgeRangeInvalid": "Start age range is not valid",
   "status": "Status",