(feat) O3-4194 Ward App - add ability to cancel pending admit / trans… #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chibongho
requested review from
mseaton,
mogoodrich,
vasharma05 and
usamaidrsk
|
Size Change: +419 B (+0.01%) Total Size: 6.67 MB ℹ️ View Unchanged
|
mogoodrich
requested changes
Nov 12, 2024
There was a problem hiding this comment.
Generally looks good @chibongho but see my comment about the structure of the deny admission obs... it's just a stand-alone question and answer, not a disposition.
|
|
||
| createEncounter(patient, emrConfiguration?.cancelADTRequestEncounterType, [ | ||
| { | ||
| concept: emrConfiguration?.dispositionDescriptor?.dispositionSetConcept?.uuid, |
There was a problem hiding this comment.
This actually doesn't belong with an disposition set. The obs can just be stored directly on on the encounter.
There was a problem hiding this comment.
Wait... I think that's what I'm doing? This array is an array of obs for the encounter.
There was a problem hiding this comment.
nvm... I think I know what you mean now. It should be just obs instead.
denniskigen
reviewed
Nov 12, 2024
...-app/src/ward-workspace/cancel-admission-request-workspace/cancel-admission-request.test.tsx
Outdated
Show resolved
Hide resolved
packages/esm-ward-app/src/ward-patient-card/row-elements/ward-patient-pending-transfer.tsx
Outdated
Show resolved
Hide resolved
…est-workspace/cancel-admission-request.test.tsx Co-authored-by: Dennis Kigen <[email protected]>
denniskigen
reviewed
Nov 12, 2024
There was a problem hiding this comment.
LGTM, but I defer to @mogoodrich on the deny admission obs stuff.
mogoodrich
approved these changes
Nov 12, 2024
| }, | ||
| ]; | ||
|
|
||
| createEncounter(patient, emrConfiguration?.cancelADTRequestEncounterType, obs) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…fer requests
Requirements
Summary
This PR adds the ability for us to cancel pending admit or transfer requests of a patient.
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-4194
Other