(chore) Extend ESLint configuration #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniskigen
requested review from
jwnasambu,
vasharma05,
jayasanka-sack and
ibacher
|
Size Change: -283 kB (-9%) ✅ Total Size: 2.83 MB
ℹ️ View Unchanged
|
denniskigen
force-pushed
the
chore/lint-consistent-type-imports
branch
from
fa814c9 to
d560aef
Compare
|
Wow! @denniskigen this LGTM! I believe its gonna save us on the errors we have been struggling with locally. |
There was a problem hiding this comment.
Thanks for the PR, @denniskigen! It's so nice to see efforts toward making our codebase cleaner.
I'm curious about why we're excluding test files from these rules. Personally, I lean towards having consistent rules across both application and test files.
3 tasks
denniskigen
force-pushed
the
chore/lint-consistent-type-imports
branch
from
d560aef to
5adef9d
Compare
|
That's fair, @jayasanka-sack. I think I only plopped that in there because we historically omitted tests from linting. I've removed |
* (chore) Bump testing dependencies and fix test console warnings * Remove unused file from registration app tsconfig * Commit some orphaned translations * Cleanup * Fixup * Review feedback - fixup * Update playwright version in e2e Dockerfile
denniskigen
force-pushed
the
chore/lint-consistent-type-imports
branch
from
5adef9d to
3e8a9a9
Compare
|
Should be good to go, @jayasanka-sack @ibacher. The PR in Core mentioned above got merged. |
ibacher
approved these changes
Dec 21, 2023
|
I'd tend to be more on board with updating the linting rules and then applying them to tests in another PR, but since it's done, it's done (as a rule, its better to have many smaller commits than a few large commits and it's better to have commits that make as small a change as possible at a time). Thanks @denniskigen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
In this PR, I've extended the ESLint configuration used in this project as follows:
@typescript-eslint/consistent-type-importsrule to enforce consistent usage of theimport typesyntax for type imports.no-consolerule to throw an error for any console statement except those using warn and error.I've made some other tangential changes, including:
.tsxtots.pretty-quickwithlint-stagedas our pre-commit hooks library becausepretty-quickis not compatible with the latest versions of prettier.Screenshots
None
Related Issue
None
Other
None