Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis fails on pre-commit command #193

Open
bitsgalore opened this issue Dec 12, 2022 · 3 comments
Open

Travis fails on pre-commit command #193

bitsgalore opened this issue Dec 12, 2022 · 3 comments
Assignees

Comments

@bitsgalore
Copy link
Member

Looking at the Travis results of the latest builds (most recent one here), it looks like something goes wrong setting up the environment for the pre-commit command. See Travis output starting at:

https://app.travis-ci.com/github/openpreserve/jpylyzer/jobs/587417609#L424

And the root cause appears to be:

https://app.travis-ci.com/github/openpreserve/jpylyzer/jobs/587417609#L446

ERROR: No matching distribution found for tomli (from autopep8>=1.3->pre-commit-hooks==1.4.0)

The pre-commit-hooks version is defined here. The 1.4.0 version specified there is pretty old (latest version is 4.3.0).

@bitsgalore
Copy link
Member Author

Tried updating pre-commit-hooks to latest version:

3aa8aae

Pushing changes doesn't trigger new Travis build. Perhaps @darrendignam or @carlwilson could have a look at this some time (I don't really understand Travis that well)?

@carlwilson
Copy link
Member

Hi @bitsgalore how would you feel about moving the build to GitHub actions instead? We're now using that for most of our projects, it's a bit more modular and flexible, it's also quicker. If you're happy I'll get this done in the next weeks.

@carlwilson carlwilson self-assigned this Mar 23, 2023
@bitsgalore
Copy link
Member Author

@carlwilson Fine with me, thanks for looking into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants